feat(FR-2632): add default fallback and error card UI for STokenLoginBoundary by nowgnuesLee · Pull Request #6855 · lablup/backend.ai-webui

nowgnuesLee · 2026-04-21T14:53:48Z

Resolves FR-2632 (sub-task of Epic FR-2616)

resolves #NNN (FR-MMM)

Checklist: (if applicable)

Documentation
Minium required manager version
Specific setting for review (eg., KB link, endpoint or how to setup)
Minimum requirements to check during review
Test case(s) to demonstrate the difference of before/after

Stack

This PR is part of the Story 1 stack for Epic FR-2616 (Extract sToken login flow into reusable boundary component). See the dev plan for the full scope. The Story 1 PR stack is #6850 → #6851 → #6852 → #6853 → #6854 → #6855 → #6856 on top of spec PR #6828.

nowgnuesLee · 2026-04-21T14:53:59Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

flow:merge-queue - adds this PR to the back of the merge queue
flow:hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has required the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

github-actions · 2026-04-21T14:56:55Z

Coverage report for `./react`

St.^❔	Category	Percentage	Covered / Total
🔴	Statements	8.55% (-0.01% 🔻)	1757/20559
🔴	Branches	7.84% (-0% 🔻)	1131/14421
🔴	Functions	5.12% (-0% 🔻)	285/5565
🔴	Lines	8.27% (-0.01% 🔻)	1649/19948

Test suite run success

856 tests passing in 39 suites.

Report generated by 🧪jest coverage report action from d67b34a

Copilot

Pull request overview

Adds a polished, localized default loading fallback and built-in error card UI for STokenLoginBoundary, so callers can rely on sensible UI even when custom fallback / errorFallback aren’t provided.

Changes:

Added new sTokenLoginBoundary.* i18n strings (currently in en/ko).
Replaced placeholder fallback with a BAICard + Spin loading card using i18n strings.
Replaced placeholder error UI with a BAICard error card including “Retry” and “Copy error details” actions, with kind→i18n-key mapping.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File	Description
resources/i18n/en.json	Adds `sTokenLoginBoundary` English strings used by the new fallback/error UI.
resources/i18n/ko.json	Adds `sTokenLoginBoundary` Korean strings used by the new fallback/error UI.
react/src/components/STokenLoginBoundary.tsx	Implements the new default fallback and error card UI (BAI components + i18n).

yomybaby

LGTM

graphite-app · 2026-04-23T10:31:29Z

Merge activity

Apr 23, 10:31 AM UTC: yomybaby added this pull request to the Graphite merge queue.
Apr 23, 10:43 AM UTC: Merged by the Graphite merge queue.

…Boundary (#6855) Resolves FR-2632 (sub-task of Epic [FR-2616](https://lablup.atlassian.net/browse/FR-2616)) resolves #NNN (FR-MMM)   **Checklist:** (if applicable) - [ ] Documentation - [ ] Minium required manager version - [ ] Specific setting for review (eg., KB link, endpoint or how to setup) - [ ] Minimum requirements to check during review - [ ] Test case(s) to demonstrate the difference of before/after ## Stack This PR is part of the Story 1 stack for Epic FR-2616 (Extract sToken login flow into reusable boundary component). See the [dev plan](../blob/main/.specs/draft-stoken-login-boundary/dev-plan.md) for the full scope. The Story 1 PR stack is #6850 → #6851 → #6852 → #6853 → #6854 → #6855 → #6856 on top of spec PR #6828. [FR-2616]: https://lablup.atlassian.net/browse/FR-2616?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ

…int (#6850) Resolves FR-2628 (sub-task of Epic [FR-2616](https://lablup.atlassian.net/browse/FR-2616)) resolves #NNN (FR-MMM)   **Checklist:** (if applicable) - [ ] Documentation - [ ] Minium required manager version - [ ] Specific setting for review (eg., KB link, endpoint or how to setup) - [ ] Minimum requirements to check during review - [ ] Test case(s) to demonstrate the difference of before/after ## Stack This PR is part of the Story 1 stack for Epic FR-2616 (Extract sToken login flow into reusable boundary component). See the [dev plan](../blob/main/.specs/draft-stoken-login-boundary/dev-plan.md) for the full scope. The Story 1 PR stack is #6850 → #6851 → #6852 → #6853 → #6854 → #6855 → #6856 on top of spec PR #6828. [FR-2616]: https://lablup.atlassian.net/browse/FR-2616?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ

) Resolves FR-2629 (sub-task of Epic [FR-2616](https://lablup.atlassian.net/browse/FR-2616)) resolves #NNN (FR-MMM)   **Checklist:** (if applicable) - [ ] Documentation - [ ] Minium required manager version - [ ] Specific setting for review (eg., KB link, endpoint or how to setup) - [ ] Minimum requirements to check during review - [ ] Test case(s) to demonstrate the difference of before/after ## Stack This PR is part of the Story 1 stack for Epic FR-2616 (Extract sToken login flow into reusable boundary component). See the [dev plan](../blob/main/.specs/draft-stoken-login-boundary/dev-plan.md) for the full scope. The Story 1 PR stack is #6850 → #6851 → #6852 → #6853 → #6854 → #6855 → #6856 on top of spec PR #6828. [FR-2616]: https://lablup.atlassian.net/browse/FR-2616?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ

…rning (#6852) Resolves FR-2630 (sub-task of Epic [FR-2616](https://lablup.atlassian.net/browse/FR-2616)) resolves #NNN (FR-MMM)   **Checklist:** (if applicable) - [ ] Documentation - [ ] Minium required manager version - [ ] Specific setting for review (eg., KB link, endpoint or how to setup) - [ ] Minimum requirements to check during review - [ ] Test case(s) to demonstrate the difference of before/after ## Stack This PR is part of the Story 1 stack for Epic FR-2616 (Extract sToken login flow into reusable boundary component). See the [dev plan](../blob/main/.specs/draft-stoken-login-boundary/dev-plan.md) for the full scope. The Story 1 PR stack is #6850 → #6851 → #6852 → #6853 → #6854 → #6855 → #6856 on top of spec PR #6828. [FR-2616]: https://lablup.atlassian.net/browse/FR-2616?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ

Resolves FR-2631 (sub-task of Epic [FR-2616](https://lablup.atlassian.net/browse/FR-2616)) resolves #NNN (FR-MMM)   **Checklist:** (if applicable) - [ ] Documentation - [ ] Minium required manager version - [ ] Specific setting for review (eg., KB link, endpoint or how to setup) - [ ] Minimum requirements to check during review - [ ] Test case(s) to demonstrate the difference of before/after ## Stack This PR is part of the Story 1 stack for Epic FR-2616 (Extract sToken login flow into reusable boundary component). See the [dev plan](../blob/main/.specs/draft-stoken-login-boundary/dev-plan.md) for the full scope. The Story 1 PR stack is #6850 → #6851 → #6852 → #6853 → #6854 → #6855 → #6856 on top of spec PR #6828. [FR-2616]: https://lablup.atlassian.net/browse/FR-2616?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ

Resolves FR-2633 (sub-task of Epic [FR-2616](https://lablup.atlassian.net/browse/FR-2616)) resolves #NNN (FR-MMM)   **Checklist:** (if applicable) - [ ] Documentation - [ ] Minium required manager version - [ ] Specific setting for review (eg., KB link, endpoint or how to setup) - [ ] Minimum requirements to check during review - [ ] Test case(s) to demonstrate the difference of before/after ## Stack This PR is part of the Story 1 stack for Epic FR-2616 (Extract sToken login flow into reusable boundary component). See the [dev plan](../blob/main/.specs/draft-stoken-login-boundary/dev-plan.md) for the full scope. The Story 1 PR stack is #6850 → #6851 → #6852 → #6853 → #6854 → #6855 → #6856 on top of spec PR #6828. [FR-2616]: https://lablup.atlassian.net/browse/FR-2616?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ

github-actions Bot assigned nowgnuesLee Apr 21, 2026

github-actions Bot added area:ux UI / UX issue. area:i18n Localization size:L 100~500 LoC labels Apr 21, 2026

nowgnuesLee mentioned this pull request Apr 21, 2026

test(FR-2633): add unit tests for STokenLoginBoundary #6856

Merged

5 tasks

nowgnuesLee mentioned this pull request Apr 22, 2026

refactor(FR-2616): rely on React Compiler ('use memo') for memoization #6857

Merged

5 tasks

nowgnuesLee changed the base branch from 04-21-feat_fr-2634_add_ci_grep_rule_forbidding_url_apis_in_stokenloginboundary to graphite-base/6855 April 22, 2026 02:00

nowgnuesLee force-pushed the 04-21-feat_fr-2632_add_default_fallback_and_error_card_ui_for_stokenloginboundary branch from c5e84f6 to a78c902 Compare April 22, 2026 02:00

nowgnuesLee force-pushed the graphite-base/6855 branch 2 times, most recently from 082b3a1 to cc085c9 Compare April 22, 2026 02:38

nowgnuesLee force-pushed the 04-21-feat_fr-2632_add_default_fallback_and_error_card_ui_for_stokenloginboundary branch from a78c902 to f3b64cb Compare April 22, 2026 02:38

nowgnuesLee changed the base branch from graphite-base/6855 to 04-21-feat_fr-2631_implement_stokenloginboundary_component_core April 22, 2026 02:38

This was referenced Apr 22, 2026

feat(FR-2626): migrate LoginView sToken path to STokenLoginBoundary #6861

Merged

feat(FR-2627): migrate EduAppLauncher sToken path to STokenLoginBoundary #6864

Merged

test(FR-2639): add E2E regression for sToken login boundary routes #6865

Merged

nowgnuesLee force-pushed the 04-21-feat_fr-2632_add_default_fallback_and_error_card_ui_for_stokenloginboundary branch from f3b64cb to 8db7fbf Compare April 22, 2026 03:43

nowgnuesLee force-pushed the 04-21-feat_fr-2631_implement_stokenloginboundary_component_core branch 2 times, most recently from 0737f09 to 8b0c4ca Compare April 22, 2026 03:53

nowgnuesLee force-pushed the 04-21-feat_fr-2632_add_default_fallback_and_error_card_ui_for_stokenloginboundary branch from 8db7fbf to e062d6a Compare April 22, 2026 03:53

This was referenced Apr 22, 2026

fix(FR-2627): forward api_version/date/endpoint to token_login #6893

Closed

feat(FR-2616): handle totp and concurrent-session inline in STokenLoginBoundary #6897

Merged

nowgnuesLee marked this pull request as ready for review April 23, 2026 06:09

Copilot AI review requested due to automatic review settings April 23, 2026 06:09

Copilot started reviewing on behalf of nowgnuesLee April 23, 2026 06:10 View session

Copilot AI reviewed Apr 23, 2026

View reviewed changes

Comment thread resources/i18n/en.json

Comment thread react/src/components/STokenLoginBoundary.tsx Outdated

Comment thread react/src/components/STokenLoginBoundary.tsx Outdated

nowgnuesLee force-pushed the 04-21-feat_fr-2631_implement_stokenloginboundary_component_core branch from 8b0c4ca to ddc7039 Compare April 23, 2026 07:57

nowgnuesLee force-pushed the 04-21-feat_fr-2632_add_default_fallback_and_error_card_ui_for_stokenloginboundary branch 2 times, most recently from 9ae4ae8 to 457e15d Compare April 23, 2026 08:02

nowgnuesLee force-pushed the 04-21-feat_fr-2631_implement_stokenloginboundary_component_core branch 2 times, most recently from 42656be to 546add2 Compare April 23, 2026 08:35

nowgnuesLee force-pushed the 04-21-feat_fr-2632_add_default_fallback_and_error_card_ui_for_stokenloginboundary branch from 457e15d to 1129d3d Compare April 23, 2026 08:35

github-actions Bot added size:XL 500~ LoC and removed size:L 100~500 LoC labels Apr 23, 2026

yomybaby approved these changes Apr 23, 2026

View reviewed changes

graphite-app Bot force-pushed the 04-21-feat_fr-2631_implement_stokenloginboundary_component_core branch from 546add2 to d1c71fe Compare April 23, 2026 10:34

graphite-app Bot force-pushed the 04-21-feat_fr-2632_add_default_fallback_and_error_card_ui_for_stokenloginboundary branch from 1129d3d to d67b34a Compare April 23, 2026 10:35

Base automatically changed from 04-21-feat_fr-2631_implement_stokenloginboundary_component_core to main April 23, 2026 10:42

graphite-app Bot merged commit d67b34a into main Apr 23, 2026
8 checks passed

graphite-app Bot deleted the 04-21-feat_fr-2632_add_default_fallback_and_error_card_ui_for_stokenloginboundary branch April 23, 2026 10:43

github-pages Bot temporarily deployed to github-pages April 23, 2026 10:44 Inactive

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(FR-2632): add default fallback and error card UI for STokenLoginBoundary#6855

feat(FR-2632): add default fallback and error card UI for STokenLoginBoundary#6855
graphite-app[bot] merged 1 commit into
mainfrom
04-21-feat_fr-2632_add_default_fallback_and_error_card_ui_for_stokenloginboundary

nowgnuesLee commented Apr 21, 2026 •

edited by atlassian Bot

Loading

Uh oh!

nowgnuesLee commented Apr 21, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Apr 21, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

yomybaby left a comment

Uh oh!

graphite-app Bot commented Apr 23, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

nowgnuesLee commented Apr 21, 2026 • edited by atlassian Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Stack

Uh oh!

nowgnuesLee commented Apr 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

github-actions Bot commented Apr 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage report for ./react

Test suite run success

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

yomybaby left a comment

Choose a reason for hiding this comment

Uh oh!

graphite-app Bot commented Apr 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

nowgnuesLee commented Apr 21, 2026 •

edited by atlassian Bot

Loading

nowgnuesLee commented Apr 21, 2026 •

edited

Loading

github-actions Bot commented Apr 21, 2026 •

edited

Loading

Coverage report for `./react`

graphite-app Bot commented Apr 23, 2026 •

edited

Loading