Skip to content

feat(FR-2672): add AdminDeploymentListPage with extended filters gated by feature flag#6924

Closed
agatha197 wants to merge 1 commit into
graphite-base/6924from
04-22-feat_fr-2672_add_admindeploymentlistpage_with_extended_filters_gated_by_feature_flag
Closed

feat(FR-2672): add AdminDeploymentListPage with extended filters gated by feature flag#6924
agatha197 wants to merge 1 commit into
graphite-base/6924from
04-22-feat_fr-2672_add_admindeploymentlistpage_with_extended_filters_gated_by_feature_flag

Conversation

@agatha197
Copy link
Copy Markdown
Contributor

@agatha197 agatha197 commented Apr 22, 2026

Resolves #6900 (FR-2672)

Summary

Flow 6 of the Endpoint → Deployment migration. Replaces the stub AdminDeploymentListPage (introduced by FR-2664) with a real admin list page that owns the adminDeployments Relay query and renders <DeploymentList mode="admin" />.

Changes

  • Replaces react/src/pages/AdminDeploymentListPage.tsx with a functional admin list page:
    • Owns useLazyLoadQuery<AdminDeploymentListPageQuery> on the adminDeployments root field (admin-only, sees all deployments regardless of owner).
    • URL-synced filter, sort, page, pageSize via nuqs useQueryStates + useBAIPaginationOptionStateOnSearchParam.
    • JSON-serialized DeploymentFilter in the URL, compact FIELD:DIR sort encoding.
    • Passes connection fragment through to <DeploymentList mode="admin" />mode="admin" opts the list into the Owner column, and DeploymentList internally gates extended filters (Domain / Resource Group / Created At) on baiClient.supports('model-deployment-extended-filter') (26.4.3+).
    • Row click navigates to /deployments/:deploymentId (shared detail route).
    • BAIFetchKeyButton for manual reload / auto-refresh.
    • Wrapped in BAICard with title t('deployment.AdminDeployments').
    • No "Create Deployment" CTA on the admin list — the admin view observes all deployments across owners; creation is a user flow.

Dependencies

Verification

bash scripts/verify.sh
...
=== ALL PASS ===

Checklist

  • 'use memo' on both components
  • i18n: deployment.AdminDeployments for page title (existing key)
  • Extended admin filters gated by baiClient.supports('model-deployment-extended-filter') (behaviour lives in DeploymentList — this page just passes mode="admin")
  • No hard-coded strings, no debug artifacts, no TODO(needs-backend) markers remaining for FR-2672 itself

@github-actions github-actions Bot added the size:L 100~500 LoC label Apr 22, 2026
Copy link
Copy Markdown
Contributor Author

agatha197 commented Apr 22, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • flow:merge-queue - adds this PR to the back of the merge queue
  • flow:hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has required the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 22, 2026

Coverage report for ./react

St.
Category Percentage Covered / Total
🔴 Statements
8.3% (-0.01% 🔻)
1758/21171
🔴 Branches
7.63% (-0.02% 🔻)
1131/14824
🔴 Functions
5% (+0.01% 🔼)
286/5724
🔴 Lines
8.03% (-0.01% 🔻)
1650/20537
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🔴
... / AdminDeploymentListPage.tsx
0%
0% (-100% 🔻)
0% 0%

Test suite run success

856 tests passing in 39 suites.

Report generated by 🧪jest coverage report action from c32bf01

@agatha197 agatha197 changed the base branch from worktree-agent-a4bb3237 to main April 22, 2026 11:36
@agatha197 agatha197 changed the base branch from main to graphite-base/6924 April 22, 2026 14:02
@agatha197 agatha197 force-pushed the 04-22-feat_fr-2672_add_admindeploymentlistpage_with_extended_filters_gated_by_feature_flag branch from 58a5f33 to c32bf01 Compare April 22, 2026 14:02
This was referenced Apr 22, 2026
@agatha197
Copy link
Copy Markdown
Contributor Author

Consolidated into grouped PR stack (Foundation/Components/Launcher/List/Detail). Closing this individual PR.

@agatha197 agatha197 closed this Apr 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L 100~500 LoC

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deployment UI Phase 3 — Deployment list pages (user + admin)

1 participant