Skip to content

feat(FR-2671): add DeploymentListPage with myDeployments query and URL state#6925

Closed
agatha197 wants to merge 1 commit into
04-22-feat_fr-2675_add_deploymentlauncherpage_with_create_edit_mutationsfrom
04-22-feat_fr-2671_add_deploymentlistpage_with_mydeployments_query_and_url_state
Closed

feat(FR-2671): add DeploymentListPage with myDeployments query and URL state#6925
agatha197 wants to merge 1 commit into
04-22-feat_fr-2675_add_deploymentlauncherpage_with_create_edit_mutationsfrom
04-22-feat_fr-2671_add_deploymentlistpage_with_mydeployments_query_and_url_state

Conversation

@agatha197
Copy link
Copy Markdown
Contributor

Resolves #FR-2671

Summary

Replaces the placeholder stub at react/src/pages/DeploymentListPage.tsx (introduced by FR-2664) with the real user-facing deployment list page for Flow 1 of the Endpoint → Deployment UI migration.

The page:

  • Owns the myDeployments Relay query (root field queries deployments for the current user; see data/schema.graphql).
  • Spreads the DeploymentList_modelDeploymentConnection fragment from FR-2670 so the table component handles its own columns, filter chips, and sort mapping.
  • Passes mode="user" into so the admin-only Owner column and extended (Domain / Resource Group / CreatedAt) filters stay off.
  • Wraps the table in a BAICard with title t('deployment.Deployments') and a Create Deployment CTA in the card extra slot, wired to /deployments/new.
  • Syncs filter / sort / page / pageSize with the URL via nuqs (parseAsString for filter/sort, parseAsInteger.withDefault(1) / parseAsInteger.withDefault(10) for pagination) so views survive refresh and are link-shareable.
  • Navigates /deployments/:deploymentId on row click, converting the Relay global ID returned by DeploymentList to a local UUID with toLocalId.

Dependencies

Stacks on top of FR-2670 (DeploymentList table). Also depends on FR-2666 (Deployment i18n keys) which is in the same stack, and FR-2664 (route stub) which the new page replaces.

Test plan

  • scripts/verify.sh passes (Relay, Lint, Format, TypeScript) — ALL PASS locally.
  • /deployments renders the user's own deployments, filter / sort / page state reflected in the URL.
  • Row click navigates to /deployments/:deploymentId.
  • Create Deployment button navigates to /deployments/new.

@github-actions github-actions Bot added the size:L 100~500 LoC label Apr 22, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 22, 2026

Coverage report for ./react

St.
Category Percentage Covered / Total
🔴 Statements
8.32% (-0.02% 🔻)
1757/21116
🔴 Branches
7.64% (-0.01% 🔻)
1131/14794
🔴 Functions
4.99% (-0.01% 🔻)
285/5713
🔴 Lines
8.05% (-0.01% 🔻)
1649/20487
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🔴
... / DeploymentListPage.tsx
0%
0% (-100% 🔻)
0% 0%

Test suite run success

856 tests passing in 39 suites.

Report generated by 🧪jest coverage report action from c35aa63

@agatha197 agatha197 changed the base branch from 04-22-feat_fr-2670_add_deploymentlist_fragment-receiving_table_with_server-side_filter_sort_paginate to graphite-base/6925 April 22, 2026 14:02
@agatha197 agatha197 force-pushed the 04-22-feat_fr-2671_add_deploymentlistpage_with_mydeployments_query_and_url_state branch from 7613093 to c35aa63 Compare April 22, 2026 14:02
@agatha197 agatha197 changed the base branch from graphite-base/6925 to 04-22-feat_fr-2675_add_deploymentlauncherpage_with_create_edit_mutations April 22, 2026 14:03
This was referenced Apr 22, 2026
Copy link
Copy Markdown
Contributor Author

agatha197 commented Apr 22, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • flow:merge-queue - adds this PR to the back of the merge queue
  • flow:hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has required the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@agatha197
Copy link
Copy Markdown
Contributor Author

Consolidated into grouped PR stack (Foundation/Components/Launcher/List/Detail). Closing this individual PR.

@agatha197 agatha197 closed this Apr 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L 100~500 LoC

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant