feat(FR-2835): add auto-activate option to Add Revision modal#7289
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
56c7a2e to
73e58ea
Compare
There was a problem hiding this comment.
Pull request overview
Adds a user-controllable “auto-activate” option to the deployment Add Revision modal, allowing users to add a revision without immediately switching traffic to it while keeping the default behavior unchanged.
Changes:
- Adds an
autoActivatecheckbox to the Add Revision form (defaulttrue). - Passes the form value through to
addModelRevision(input.options.autoActivate)instead of hard-codingtrue. - Adds
deployment.AutoActivatei18n strings across all supported locales.
Reviewed changes
Copilot reviewed 23 out of 23 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| react/src/components/DeploymentAddRevisionModal.tsx | Adds the checkbox to the modal form and wires its value into the addModelRevision mutation options. |
| data/schema.graphql | Updates the schema snapshot (note: includes removal of ModelRevision.name, which currently breaks existing frontend queries). |
| resources/i18n/en.json | Adds deployment.AutoActivate translation. |
| resources/i18n/ko.json | Adds deployment.AutoActivate translation. |
| resources/i18n/ja.json | Adds deployment.AutoActivate translation. |
| resources/i18n/zh-CN.json | Adds deployment.AutoActivate translation. |
| resources/i18n/zh-TW.json | Adds deployment.AutoActivate translation. |
| resources/i18n/de.json | Adds deployment.AutoActivate translation. |
| resources/i18n/fr.json | Adds deployment.AutoActivate translation. |
| resources/i18n/es.json | Adds deployment.AutoActivate translation. |
| resources/i18n/it.json | Adds deployment.AutoActivate translation. |
| resources/i18n/pt.json | Adds deployment.AutoActivate translation. |
| resources/i18n/pt-BR.json | Adds deployment.AutoActivate translation. |
| resources/i18n/ru.json | Adds deployment.AutoActivate translation. |
| resources/i18n/pl.json | Adds deployment.AutoActivate translation. |
| resources/i18n/tr.json | Adds deployment.AutoActivate translation. |
| resources/i18n/th.json | Adds deployment.AutoActivate translation. |
| resources/i18n/vi.json | Adds deployment.AutoActivate translation. |
| resources/i18n/id.json | Adds deployment.AutoActivate translation. |
| resources/i18n/ms.json | Adds deployment.AutoActivate translation. |
| resources/i18n/mn.json | Adds deployment.AutoActivate translation. |
| resources/i18n/fi.json | Adds deployment.AutoActivate translation. |
| resources/i18n/el.json | Adds deployment.AutoActivate translation. |
Resolves #7295(FR-2839) ## Summary `pnpm/action-setup` was using `version: latest`, which now resolves to **pnpm 11.0.8**. This conflicts with this repo's `engines.pnpm: ^10.16.0` (and `engine-strict=true` in `.npmrc`), causing every CI install step to fail with: ``` ERR_PNPM_UNSUPPORTED_ENGINE Expected version: ^10.16.0 Got: 11.0.8 ``` Example failure on PR #7289 (`react-vitest` job): https://github.com/lablup/backend.ai-webui/actions/runs/25532505739/job/74941615237 Pin all 11 `pnpm/action-setup` invocations to `version: 10` so CI tracks the latest 10.x release and stops drifting onto v11. The full pnpm v11 migration (config moves, `onlyBuiltDependencies` → `allowBuilds`, lockfile regen, audit GHSA migration, etc.) is tracked separately under #7296(FR-2840). ## Changes - `.github/workflows/vitest.yml` — 3 occurrences - `.github/workflows/package.yml` — 4 occurrences - `.github/workflows/publish-backend.ai-ui.yml` — 1 occurrence - `.github/workflows/publish-backend.ai-docs-toolkit.yml` — 1 occurrence - `.github/workflows/weekly-merge-branch-lockfiles.yml` — 1 occurrence - `.github/actions/daily-test-improver/coverage-steps/action.yml` — 1 occurrence (composite action used by `daily-test-improver`) `grep -rn "version: latest" .github/` returns no results after this change. No application code, lockfile, or `package.json` changes. ## Test plan - [ ] After merge, re-run failed CI on a recent PR (e.g. #7289) and verify the install step passes. - [ ] Confirm `pnpm -v` in CI logs reports a 10.x version. - [ ] No regression on the `Analyze` / `CodeQL` / `triage` checks (they don't use pnpm).
Merge activity
|
Resolves #7288 ([FR-2835](https://lablup.atlassian.net/browse/FR-2835)) ## Summary - Add `Auto-activate after adding` checkbox to the `Add Revision` modal so users can opt out of immediate activation when adding a new revision. - Default value is `true`, preserving existing behavior. - Wire the form value through to the `addModelRevision` mutation's `options.autoActivate` (previously hard-coded to `true`). - Add `deployment.AutoActivate` i18n key and translate it across all 21 supported locales. -  ## Test plan - [ ] Open the deployment page and click `Add Revision`. - [ ] Verify the new `Auto-activate after adding` checkbox is visible right under the revision name and is checked by default. - [ ] Submit with the box checked → newly added revision becomes the active revision (existing behavior). - [ ] Submit with the box unchecked → revision is added but does not become active. - [ ] Verify locale switch shows the translated label correctly. [FR-2835]: https://lablup.atlassian.net/browse/FR-2835?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
73e58ea to
316c42a
Compare
…al (#7291) Resolves #7290 ([FR-2836](https://lablup.atlassian.net/browse/FR-2836)) > Stacked on top of #7289 ## Summary - Remove the unused `Revision Name` text input from the `Add Revision` modal. - Drop `name` from the `FormValues` type and from the `addModelRevision` mutation payload. - Delete the now-unused i18n keys `deployment.RevisionName` and `deployment.RevisionNamePlaceholder` across all 21 supported locales. ## Test plan - [ ] Open the deployment page and click `Add Revision`. - [ ] Verify the `Revision Name` input is no longer present. - [ ] Submit the modal — the new revision is created without sending a `name` to the backend. - [ ] Confirm no missing-i18n-key warnings appear in the dev console. [FR-2836]: https://lablup.atlassian.net/browse/FR-2836?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ

Resolves #7288 (FR-2835)
Summary
Auto-activate after addingcheckbox to theAdd Revisionmodal so users can opt out of immediate activation when adding a new revision.true, preserving existing behavior.addModelRevisionmutation'soptions.autoActivate(previously hard-coded totrue).deployment.AutoActivatei18n key and translate it across all 21 supported locales.Test plan
Add Revision.Auto-activate after addingcheckbox is visible right under the revision name and is checked by default.