Skip to content

feat(FR-2835): add auto-activate option to Add Revision modal#7289

Merged
graphite-app[bot] merged 1 commit into
mainfrom
feat/FR-2835-add-auto-activate-option
May 8, 2026
Merged

feat(FR-2835): add auto-activate option to Add Revision modal#7289
graphite-app[bot] merged 1 commit into
mainfrom
feat/FR-2835-add-auto-activate-option

Conversation

@agatha197
Copy link
Copy Markdown
Contributor

@agatha197 agatha197 commented May 8, 2026

Resolves #7288 (FR-2835)

Summary

  • Add Auto-activate after adding checkbox to the Add Revision modal so users can opt out of immediate activation when adding a new revision.
  • Default value is true, preserving existing behavior.
  • Wire the form value through to the addModelRevision mutation's options.autoActivate (previously hard-coded to true).
  • Add deployment.AutoActivate i18n key and translate it across all 21 supported locales.
  • image.png

Test plan

  • Open the deployment page and click Add Revision.
  • Verify the new Auto-activate after adding checkbox is visible right under the revision name and is checked by default.
  • Submit with the box checked → newly added revision becomes the active revision (existing behavior).
  • Submit with the box unchecked → revision is added but does not become active.
  • Verify locale switch shows the translated label correctly.

Copy link
Copy Markdown
Contributor Author

agatha197 commented May 8, 2026


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • flow:merge-queue - adds this PR to the back of the merge queue
  • flow:hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has required the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions Bot added area:ux UI / UX issue. area:i18n Localization size:S 10~30 LoC labels May 8, 2026
@agatha197 agatha197 marked this pull request as ready for review May 8, 2026 00:28
@agatha197 agatha197 requested review from Copilot and yomybaby and removed request for Copilot May 8, 2026 00:28
@agatha197 agatha197 force-pushed the feat/FR-2835-add-auto-activate-option branch from 56c7a2e to 73e58ea Compare May 8, 2026 02:04
Copilot AI review requested due to automatic review settings May 8, 2026 02:04
@github-actions github-actions Bot added size:M 30~100 LoC and removed size:S 10~30 LoC labels May 8, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a user-controllable “auto-activate” option to the deployment Add Revision modal, allowing users to add a revision without immediately switching traffic to it while keeping the default behavior unchanged.

Changes:

  • Adds an autoActivate checkbox to the Add Revision form (default true).
  • Passes the form value through to addModelRevision(input.options.autoActivate) instead of hard-coding true.
  • Adds deployment.AutoActivate i18n strings across all supported locales.

Reviewed changes

Copilot reviewed 23 out of 23 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
react/src/components/DeploymentAddRevisionModal.tsx Adds the checkbox to the modal form and wires its value into the addModelRevision mutation options.
data/schema.graphql Updates the schema snapshot (note: includes removal of ModelRevision.name, which currently breaks existing frontend queries).
resources/i18n/en.json Adds deployment.AutoActivate translation.
resources/i18n/ko.json Adds deployment.AutoActivate translation.
resources/i18n/ja.json Adds deployment.AutoActivate translation.
resources/i18n/zh-CN.json Adds deployment.AutoActivate translation.
resources/i18n/zh-TW.json Adds deployment.AutoActivate translation.
resources/i18n/de.json Adds deployment.AutoActivate translation.
resources/i18n/fr.json Adds deployment.AutoActivate translation.
resources/i18n/es.json Adds deployment.AutoActivate translation.
resources/i18n/it.json Adds deployment.AutoActivate translation.
resources/i18n/pt.json Adds deployment.AutoActivate translation.
resources/i18n/pt-BR.json Adds deployment.AutoActivate translation.
resources/i18n/ru.json Adds deployment.AutoActivate translation.
resources/i18n/pl.json Adds deployment.AutoActivate translation.
resources/i18n/tr.json Adds deployment.AutoActivate translation.
resources/i18n/th.json Adds deployment.AutoActivate translation.
resources/i18n/vi.json Adds deployment.AutoActivate translation.
resources/i18n/id.json Adds deployment.AutoActivate translation.
resources/i18n/ms.json Adds deployment.AutoActivate translation.
resources/i18n/mn.json Adds deployment.AutoActivate translation.
resources/i18n/fi.json Adds deployment.AutoActivate translation.
resources/i18n/el.json Adds deployment.AutoActivate translation.

Comment thread data/schema.graphql
graphite-app Bot pushed a commit that referenced this pull request May 8, 2026
Resolves #7295(FR-2839)

## Summary

`pnpm/action-setup` was using `version: latest`, which now resolves to **pnpm 11.0.8**. This conflicts with this repo's `engines.pnpm: ^10.16.0` (and `engine-strict=true` in `.npmrc`), causing every CI install step to fail with:

```
ERR_PNPM_UNSUPPORTED_ENGINE
Expected version: ^10.16.0
Got: 11.0.8
```

Example failure on PR #7289 (`react-vitest` job): https://github.com/lablup/backend.ai-webui/actions/runs/25532505739/job/74941615237

Pin all 11 `pnpm/action-setup` invocations to `version: 10` so CI tracks the latest 10.x release and stops drifting onto v11. The full pnpm v11 migration (config moves, `onlyBuiltDependencies` → `allowBuilds`, lockfile regen, audit GHSA migration, etc.) is tracked separately under #7296(FR-2840).

## Changes

- `.github/workflows/vitest.yml` — 3 occurrences
- `.github/workflows/package.yml` — 4 occurrences
- `.github/workflows/publish-backend.ai-ui.yml` — 1 occurrence
- `.github/workflows/publish-backend.ai-docs-toolkit.yml` — 1 occurrence
- `.github/workflows/weekly-merge-branch-lockfiles.yml` — 1 occurrence
- `.github/actions/daily-test-improver/coverage-steps/action.yml` — 1 occurrence (composite action used by `daily-test-improver`)

`grep -rn "version: latest" .github/` returns no results after this change.

No application code, lockfile, or `package.json` changes.

## Test plan

- [ ] After merge, re-run failed CI on a recent PR (e.g. #7289) and verify the install step passes.
- [ ] Confirm `pnpm -v` in CI logs reports a 10.x version.
- [ ] No regression on the `Analyze` / `CodeQL` / `triage` checks (they don't use pnpm).
@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented May 8, 2026

Merge activity

Resolves #7288 ([FR-2835](https://lablup.atlassian.net/browse/FR-2835))

## Summary

- Add `Auto-activate after adding` checkbox to the `Add Revision` modal so users can opt out of immediate activation when adding a new revision.
- Default value is `true`, preserving existing behavior.
- Wire the form value through to the `addModelRevision` mutation's `options.autoActivate` (previously hard-coded to `true`).
- Add `deployment.AutoActivate` i18n key and translate it across all 21 supported locales.
- ![image.png](https://app.graphite.com/user-attachments/assets/711ae56d-5033-4d5f-ae4f-9c3033775831.png)

## Test plan

- [ ] Open the deployment page and click `Add Revision`.
- [ ] Verify the new `Auto-activate after adding` checkbox is visible right under the revision name and is checked by default.
- [ ] Submit with the box checked → newly added revision becomes the active revision (existing behavior).
- [ ] Submit with the box unchecked → revision is added but does not become active.
- [ ] Verify locale switch shows the translated label correctly.

[FR-2835]: https://lablup.atlassian.net/browse/FR-2835?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
@graphite-app graphite-app Bot force-pushed the feat/FR-2835-add-auto-activate-option branch from 73e58ea to 316c42a Compare May 8, 2026 09:32
@graphite-app graphite-app Bot merged commit 316c42a into main May 8, 2026
10 of 11 checks passed
@graphite-app graphite-app Bot deleted the feat/FR-2835-add-auto-activate-option branch May 8, 2026 09:33
@github-pages github-pages Bot temporarily deployed to github-pages May 8, 2026 09:34 Inactive
graphite-app Bot pushed a commit that referenced this pull request May 8, 2026
…al (#7291)

Resolves #7290 ([FR-2836](https://lablup.atlassian.net/browse/FR-2836))

> Stacked on top of #7289

## Summary
- Remove the unused `Revision Name` text input from the `Add Revision` modal.
- Drop `name` from the `FormValues` type and from the `addModelRevision` mutation payload.
- Delete the now-unused i18n keys `deployment.RevisionName` and `deployment.RevisionNamePlaceholder` across all 21 supported locales.

## Test plan
- [ ] Open the deployment page and click `Add Revision`.
- [ ] Verify the `Revision Name` input is no longer present.
- [ ] Submit the modal — the new revision is created without sending a `name` to the backend.
- [ ] Confirm no missing-i18n-key warnings appear in the dev console.

[FR-2836]: https://lablup.atlassian.net/browse/FR-2836?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:i18n Localization area:ux UI / UX issue. size:M 30~100 LoC

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add auto-activate option to Add Revision modal

2 participants