feat(FR-2904): replace replica status enum filter with running/terminated radio group#7436
Closed
Conversation
Contributor
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
5 tasks
Contributor
Author
agatha197
deleted the
05-15-feat_fr-2904_replace_replica_status_enum_filter_with_running_terminated_radio_group
branch
Contributor
Coverage Report for react-coverage (./react)
File Coverage
|
||||||||||||||||||||||||||||||||||||||
Contributor
There was a problem hiding this comment.
Pull request overview
Replaces the replica status enum-based property filter with a simpler “Running / Terminated” radio-group category filter, and wires it into the query-string + Relay query variables for the Deployment Replicas tab.
Changes:
- Added
rStatusCategoryquery param (running/terminated) and UI control viaBAIRadioGroup. - Removed
statusfromBAIGraphQLPropertyFilterproperties; status filtering is now enforced via a category-based GraphQL filter merge. - Updated initial query variables and refetch logic to apply the selected status category filter.
Comment on lines
+54
to
+56
| userFilter: Record<string, unknown> | null, | ||
| category: ReplicaStatusCategory, | ||
| ) => ({ ...userFilter, ...buildStatusFilter(category) }); |
agatha197
restored the
05-15-feat_fr-2904_replace_replica_status_enum_filter_with_running_terminated_radio_group
branch
Contributor
Author
|
Replaced by #7437 (renamed to follow project branch naming convention). |
5 tasks
agatha197
deleted the
05-15-feat_fr-2904_replace_replica_status_enum_filter_with_running_terminated_radio_group
branch
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #NNN (FR-MMM)
Checklist: (if applicable)