-
Notifications
You must be signed in to change notification settings - Fork 715
feat: lake: use lean --setup
#8447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
May 24, 2025
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Jun 2, 2025
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Jun 8, 2025
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Jun 8, 2025
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Jun 8, 2025
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Jun 8, 2025
This was referenced Jun 17, 2025
Member
Author
|
!bench |
Collaborator
|
Here are the benchmark results for commit ba6b4db. Benchmark Metric Change
========================================================================
+ Init.Data.BitVec.Lemmas re-elab branch-misses -1.3% (-21.7 σ)
+ Init.Data.List.Sublist re-elab -j4 wall-clock -1.3% (-322.4 σ)
- lake build clean instructions 40.5% (156.2 σ)
- lake build clean maxrss 93.8% (30.1 σ)
- lake build clean task-clock 36.5% (34.8 σ)
- lake build clean wall-clock 84.3% (36.0 σ)
- lake build no-op instructions 4639.7% (101.2 σ)
- lake build no-op maxrss 93.7% (203.0 σ)
- lake build no-op task-clock 15514.6% (20.2 σ)
- lake build no-op wall-clock 2438.8% (73.6 σ)
+ reduceMatch wall-clock -2.3% (-20.5 σ)
+ stdlib task-clock -1.5% (-29.2 σ) |
algebraic-dev
pushed a commit
to algebraic-dev/lean4
that referenced
this pull request
Jun 18, 2025
This PR makes use of `lean --setup` in Lake builds of Lean modules and adds Lake support for the new `.olean` artifacts produced by the module system. Lake now computes the entire transitive import graph of a module for Lean, allowing it eagerly provide the artifacts managed by Lake to Lean via the `modules` field of `lean --setup`. `lake setup-file` no longer respects the imports passed to it and instead just parses the file's header for imports. This is necessary because import statements are now more complex than a simple module name.
algebraic-dev
pushed a commit
to algebraic-dev/lean4
that referenced
this pull request
Jun 18, 2025
This PR exports `LeanOption` in the `Lean` namespace from the `Lake` namespace. `LeanOption` was moved from `Lean` to `Lake` in leanprover#8447, which can cause unnecessary breakage without this.
algebraic-dev
pushed a commit
to algebraic-dev/lean4
that referenced
this pull request
Jun 18, 2025
This PR reintroduces the basics of `lean --setup` integration into Lake without the module computation which is still undergoing performance debugging in leanprover#8787. Partially reverts leanprover#8736 and partially reimplements leanprover#8447.
wkrozowski
pushed a commit
to wkrozowski/lean4
that referenced
this pull request
Jun 24, 2025
This PR reintroduces the basics of `lean --setup` integration into Lake without the module computation which is still undergoing performance debugging in leanprover#8787. Partially reverts leanprover#8736 and partially reimplements leanprover#8447.
This was referenced Jun 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
changelog-lake
Lake
toolchain-available
A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes use of
lean --setupin Lake builds of Lean modules and adds Lake support for the new.oleanartifacts produced by the module system.Lake now computes the entire transitive import graph of a module for Lean, allowing it eagerly provide the artifacts managed by Lake to Lean via the
modulesfield oflean --setup.lake setup-fileno longer respects the imports passed to it and instead just parses the file's header for imports. This is necessary because import statements are now more complex than a simple module name.