Skip to content

[Build]: Update clean-env-dev-kind target in Makefile and fix vllm-sim image version #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kfirtoledo merged 2 commits into from
Jun 3, 2025
Merged

[Build]: Update clean-env-dev-kind target in Makefile and fix vllm-sim image version #155

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0fe938a
[build]: Add clean-env-dev-kind target to the makefile
kfirtoledo May 29, 2025
4cd9238
[fix]: Fix vllm-sim image version
kfirtoledo May 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion DEVELOPMENT.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ make env-dev-kind
```

This will build images with your recent changes and load the new images to the
cluster. By default the image tag will be `dev`. It will also load llm-d-inference-sim, using a tag of `dev` by default.
cluster. By default the image tag will be `dev`. It will also load `llm-d-inference-sim` image.

**NOTE:** The built image tag can be specified via the `EPP_TAG` environment variable so it is used in the deployment. For example:

Expand Down
13 changes: 9 additions & 4 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ test-integration: download-tokenizer
post-deploy-test: ## Run post deployment tests
echo Success!
@echo "Post-deployment tests passed."

.PHONY: lint
lint: check-golangci-lint ## Run lint
@printf "\033[33;1m==== Running linting ====\033[0m\n"
Expand Down Expand Up @@ -138,7 +138,7 @@ install-k8s: check-kubectl check-kustomize check-envsubst ## Install on Kubernet
echo "Kubernetes installation complete."; \
echo "To use the app, run:"; \
echo "alias $(PROJECT_NAME)='kubectl exec -n $(NAMESPACE) -it $$POD -- /app/$(PROJECT_NAME)'"

.PHONY: uninstall-k8s
uninstall-k8s: check-kubectl check-kustomize check-envsubst ## Uninstall from Kubernetes
export PROJECT_NAME=${PROJECT_NAME}
Expand All @@ -165,7 +165,7 @@ install-openshift: check-kubectl check-kustomize check-envsubst ## Install on Op
@POD=$$(kubectl get pod -l app=$(PROJECT_NAME)-statefulset -n $(NAMESPACE) -o jsonpath='{.items[0].metadata.name}'); \
echo "OpenShift installation complete."; \
echo "To use the app, run:"; \
echo "alias $(PROJECT_NAME)='kubectl exec -n $(NAMESPACE) -it $$POD -- /app/$(PROJECT_NAME)'"
echo "alias $(PROJECT_NAME)='kubectl exec -n $(NAMESPACE) -it $$POD -- /app/$(PROJECT_NAME)'"

.PHONY: uninstall-openshift
uninstall-openshift: check-kubectl check-kustomize check-envsubst ## Uninstall from OpenShift
Expand Down Expand Up @@ -213,7 +213,7 @@ check-tools: \
check-envsubst \
check-container-tool \
check-kubectl \
check-buildah
check-buildah
@echo "✅ All required tools are installed."

.PHONY: check-go
Expand Down Expand Up @@ -297,3 +297,8 @@ env-dev-kind: image-build
IMAGE_REGISTRY=$(IMAGE_REGISTRY) \
EPP_TAG=$(EPP_TAG) \
./scripts/kind-dev-env.sh

.PHONY: clean-env-dev-kind
clean-env-dev-kind:
@echo "INFO: cleaning up kind cluster $(KIND_CLUSTER_NAME)"
kind delete cluster --name $(KIND_CLUSTER_NAME)
2 changes: 1 addition & 1 deletion scripts/kind-dev-env.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
: "${VLLM_SIMULATOR_IMAGE:=llm-d-inference-sim}"

# Set a default VLLM_SIMULATOR_TAG if not provided
export VLLM_SIMULATOR_TAG="${VLLM_SIMULATOR_TAG:-dev}"
export VLLM_SIMULATOR_TAG="${VLLM_SIMULATOR_TAG:-v0.1.0}"

# Set a default EPP_IMAGE if not provided
: "${EPP_IMAGE:=llm-d-inference-scheduler}"
Expand Down
Loading