Skip to content

build: Upgrade golangci-lint to v2.9.0 #439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gyliu513 wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −3
Open

build: Upgrade golangci-lint to v2.9.0 #439

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci-lint.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ jobs:
- name: Install golangci-lint without running it
uses: golangci/golangci-lint-action@v8
with:
version: v2.1.6
version: v2.9.0
args: "--help"

- name: Run precommit checks with CGo environment
Expand Down
5 changes: 3 additions & 2 deletions pkg/kvevents/subscriber_manager_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ package kvevents_test

import (
"context"
"fmt"
"testing"
"time"

Expand Down Expand Up @@ -199,8 +200,8 @@ func TestSubscriberManager_ConcurrentOperations(t *testing.T) {
for i := 0; i < 10; i++ {
go func(id int) {
defer func() { done <- true }()
podID := "default/pod-" + string(rune('0'+id))
endpoint := "tcp://10.0.0." + string(rune('0'+id)) + ":5557"
podID := fmt.Sprintf("default/pod-%d", id)
endpoint := fmt.Sprintf("tcp://10.0.0.%d:5557", id)
if err := sm.EnsureSubscriber(ctx, podID, endpoint, "kv@", true); err != nil {
t.Errorf("failed to add subscriber %s: %v", podID, err)
}
Expand Down
Loading