Open
Conversation
gyliu513
requested review from
dannyharnik,
kfirtoledo,
liu-cong and
vMaroon
as code owners
Signed-off-by: Guangya Liu <gyliu513@gmail.com>
gyliu513
force-pushed
the
fix-lint-upgrade
branch
from
32e21a6 to
a90d076
Compare
gyliu513
changed the title
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed #459
The
string(rune('0'+id))pattern triggers gosec G115 (integer overflow conversionint -> rune) which is a real finding — it silently produces wrong characters forid >= 10. Usingfmt.Sprintffixes the bug and satisfies the linter.This is also trying to make the ci lint using same version as gateway-api-inference-extension https://github.com/kubernetes-sigs/gateway-api-inference-extension/blob/main/Makefile#L552