ImportVerilog: add step-1 SV interface import#9904
Open
Conversation
Contributor
fabianschuiki
left a comment
fabianschuiki
left a comment
There was a problem hiding this comment.
Hey @AmurG, thanks for kicking this off! I don't think we want to use any ops in the SV dialect in ImportVerilog. It's a bit counter-intuitive, but the SV dialect is intended for Verilog emission, but it doesn't preserve enough information for Verilog ingestion. The Moore dialect is where we deal with the ImportVerilog side of things. There is no interface support there yet, but @Mohamed-Khairy-SWE has been working towards some first support there (#9792). Could these two approaches be combined, or one built on the other?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
---This PR was based on AI-generated content---
This PR adds basic interface support for a total overhaul of the CIRCT frontend that supports UVM/Randomization well.
Kept intentionally small for basic interface/modport support and CI/human testing.