[otbn] Add OTBN simulator implementation of SIMD instructions #29232
Conversation
etterli
requested review from
andrea-caforio,
h-filali,
johannheyszl,
nasahlpa,
rswarbrick and
vogelpi
and removed request for
a team
etterli
force-pushed
the
otbn-pqc-simd-sim
branch
from
b011e7b to
5833a37
Compare
etterli
force-pushed
the
otbn-pqc-simd-sim
branch
4 times, most recently
from
2366588 to
4aa8f12
Compare
andrea-caforio
left a comment
andrea-caforio
left a comment
There was a problem hiding this comment.
I've been using this code for months at this point without problems.
etterli
force-pushed
the
otbn-pqc-simd-sim
branch
from
4aa8f12 to
ca48c13
Compare
rswarbrick
left a comment
rswarbrick
left a comment
There was a problem hiding this comment.
Some initial notes (I got as far as BNMULV).
It looks really nice though!
etterli
force-pushed
the
otbn-pqc-simd-sim
branch
2 times, most recently
from
98e6442 to
d2fd698
Compare
rswarbrick
left a comment
rswarbrick
left a comment
There was a problem hiding this comment.
Some notes here about the rest of the "Add vectorized bignum instructions" commit.
Lots of nitty notes (sorry), but I really like this! My inner functional programmer wishes that we could write things as maps over lists of lane elements that get glued together at the end, but that's a dream for a follow-up, I think :-D
rswarbrick
left a comment
rswarbrick
left a comment
There was a problem hiding this comment.
I've left a couple of notes about the penultimate commit.
For the last one, are you sure we actually need to check the files in? Rather than checking in a load of auto-generated text, I think it would be much better to check the testbench so that it can generate them on the fly.
etterli
force-pushed
the
otbn-pqc-simd-sim
branch
2 times, most recently
from
ee3d5e0 to
bdc2c64
Compare
|
@rswarbrick Thanks for the review! I adapted the points and also extended the simulator test framework that it now autogenerates most of the SIMD tests. The remaining non-generated tests are not worth the effort to write a script to auto-generate them. |
etterli
force-pushed
the
otbn-pqc-simd-sim
branch
2 times, most recently
from
d3e52b7 to
d17596c
Compare
rswarbrick
left a comment
rswarbrick
left a comment
There was a problem hiding this comment.
This is really great! Thanks!
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
etterli
force-pushed
the
otbn-pqc-simd-sim
branch
2 times, most recently
from
de7f0f7 to
545e76e
Compare
This adds the vectorized instructions to the OTBN simulator. Signed-off-by: Pascal Etterli <[email protected]>
…r test cases The vectorized instruction simulator implementation is tested against simple test programs. This adds a script which generates such programs instead of writing them by hand. Signed-off-by: Pascal Etterli <[email protected]>
This commit adds simple tests to test the simulator implementation of the vectorized instructions. Most of these tests are autogenerated when running a test using the generate_bn_simd_tests.py scripts. Signed-off-by: Pascal Etterli <[email protected]>
etterli
force-pushed
the
otbn-pqc-simd-sim
branch
from
545e76e to
f9356fc
Compare
4 participants
This PR is based upon #29231 (first 3 commits) and adds the simulator implementation for the new vectorized instructions.
Note, merging this PR will not yet resolve the issue that DV tests fail due to illegal instructions. For this the actual RTL implementation is also required.