iris smoke: remove flaky nested job-expand test#4877
Merged
Conversation
Contributor
|
Claude finished @rjpower's task in 1m 2s —— View job Code review
No issues found. Checked for bugs and CLAUDE.md/AGENTS.md compliance. Summary. Bumps the single Notes (non-blocking):
|
The test exercises the same UI widget and RPC path as test_dashboard_job_expand (which runs nested expand isn't adding any new coverage) but has been failing consistently on GCP runners: the click-triggered lazy fetch for grandchildren regularly exceeds the 10s wait_for_function timeout, seen as ~12s asyncio handle blocks. Removes the test and its only-used-here helpers (_tree_parent_job, _tree_middle_job).
ae34ded to
f3f026e
Compare
yonromai
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Deletes the test along with its only-used-here helpers (`_tree_parent_job`, `_tree_middle_job`).
Test plan