Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 0 additions & 35 deletions lib/iris/tests/e2e/helpers.py
Original file line number Diff line number Diff line change
Expand Up @@ -155,38 +155,3 @@ def wait_for_sentinel(s):

s.wait(timeout=Duration.from_seconds(2))
return "done"


# Cloud task pods run `uv sync` per pod and need ~4GB; local workers share
# a pre-built venv and would be fine with 1GB. Since these helpers execute
# inside a worker with no access to the test fixture's is_cloud flag, we
# use the cloud default unconditionally — local workers can absorb it.
_NESTED_JOB_MEMORY = "4g"


def _tree_middle_job():
"""Iris job callable: submits TestJobs.quick as a grandchild named 'tree-grandchild'."""
from iris.client.client import iris_ctx
from iris.cluster.types import Entrypoint, ResourceSpec

ctx = iris_ctx()
grandchild = ctx.client.submit(
Entrypoint.from_callable(TestJobs.quick),
"tree-grandchild",
ResourceSpec(cpu=1, memory=_NESTED_JOB_MEMORY),
)
grandchild.wait(timeout=120)


def _tree_parent_job():
"""Iris job callable: submits _tree_middle_job as a child named 'tree-child'."""
from iris.client.client import iris_ctx
from iris.cluster.types import Entrypoint, ResourceSpec

ctx = iris_ctx()
child = ctx.client.submit(
Entrypoint.from_callable(_tree_middle_job),
"tree-child",
ResourceSpec(cpu=1, memory=_NESTED_JOB_MEMORY),
)
child.wait(timeout=120)
27 changes: 1 addition & 26 deletions lib/iris/tests/e2e/test_smoke.py
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
discover_capabilities,
wait_for_dashboard_ready,
)
from .helpers import TestJobs, _tree_parent_job
from .helpers import TestJobs

logger = logging.getLogger(__name__)

Expand Down Expand Up @@ -308,31 +308,6 @@ def test_dashboard_job_detail(smoke_cluster, smoke_page, smoke_screenshot):
)


def test_dashboard_job_expand_nested(smoke_cluster, smoke_page, smoke_screenshot):
"""Expanding a child job on the job detail page reveals its grandchildren."""
root = smoke_cluster.submit(_tree_parent_job, "smoke-tree-root")
smoke_cluster.wait(root, timeout=smoke_cluster.job_timeout)

dashboard_goto(smoke_page, f"{smoke_cluster.url}/job/{root.job_id.to_wire()}")
wait_for_dashboard_ready(smoke_page)

# Child job should appear in the "Direct only" child jobs list.
smoke_page.wait_for_function(
"() => document.body.textContent.includes('tree-child')",
timeout=10000,
)
smoke_screenshot("job-expand-nested-before", "Job detail page showing tree-child as a direct child with ▶ button")

child_row = smoke_page.locator("tr", has_text="tree-child").first
child_row.get_by_role("button").filter(has_text="▶").click()

smoke_page.wait_for_function(
"() => document.body.textContent.includes('tree-grandchild')",
timeout=10000,
)
smoke_screenshot("job-expand-nested-after", "Job detail page with tree-child expanded showing tree-grandchild")


def test_dashboard_task_logs(smoke_cluster, verbose_job, smoke_page, smoke_screenshot):
"""Task logs show lines and substring filter on the task detail page."""
task_status = smoke_cluster.task_status(verbose_job)
Expand Down
Loading