Ft windows compatibility #275
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… optional dependency.
…t ones to avoid confusion and to allow the usage of mujoco without installation of pybullet.
…ions. Alligns quotation marks style.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an attempt to make this repo work on windows without C++ compiler, see #178, , it has proven to be much easier to make mujoco work. Because of that, this PR makes pybullet an optional dependency, just like mujoco. As a consequence, some structural changes were made, for example the sensor were split into pybullet and mujoco specifics.
Also, some path handling is quite different in windows and in linux, so this is being dealt with using the
syspackage to identify which version it is running on.