Fix reset_obstacles() crashes for URDF obstacles #281
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… exists when adding a urdf obstacle as the first obstacle; and a small typo issue from position to velocity.
Owner
|
@Gralerfics THanks for pointing that out and for suggesting a fix. I am not that active anymore on this repo these days, but this is a great work from you. As the build/test pipeline is slightly outdated, the tests are failing. Could you simply merge the latest develop into this branch, such that the tests are succeeding? See #282 for reference |
Contributor
Author
|
Thank you for your reply! I have merged that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Issue #280.
oriinreset_obstaclesexists when adding a urdf obstacle as the first obstacle;velassignment to prevent the object from drifting.