🌱 workflows: sync pull_request trigger types#2242
Merged
metal3-io-bot merged 1 commit intometal3-io:mainfrom Feb 11, 2025
Merged
🌱 workflows: sync pull_request trigger types#2242metal3-io-bot merged 1 commit intometal3-io:mainfrom
metal3-io-bot merged 1 commit intometal3-io:mainfrom
Conversation
We have "edited" as leftover workaround from days before we had "PR auto-reapprover" workflow in some jobs. In some jobs it is specifically needed as those workflows check the PR metadata which is covered by the edited. Add "ready_for_review" for consistency as a trigger type as well. Similar PRs will be pushed across Metal3 repos to make things consistent after discussion in ironic-image PR. Signed-off-by: Tuomo Tanskanen <tuomo.tanskanen@est.tech>
metal3-io-bot
added
the
size/S
This was referenced Feb 10, 2025
Member
Author
|
/hold Since the idea is to get these consistent, I'm holding until all of the PRs have flags. |
metal3-io-bot
added
the
do-not-merge/hold
This was referenced Feb 10, 2025
Member
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dtantsur The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
metal3-io-bot
added
the
approved
Member
Author
|
/retest |
Member
Author
|
/cc @lentzi90 |
Member
Author
|
/unhold |
metal3-io-bot
removed
the
do-not-merge/hold
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have "edited" as leftover workaround from days before we had "PR auto-reapprover" workflow in some jobs. In some jobs it is specifically needed as those workflows check the PR metadata which is covered by the edited. Add "ready_for_review" for consistency as a trigger type as well.
Similar PRs will be pushed across Metal3 repos to make things consistent after discussion in ironic-image PR.