Skip to content

🌱 Run the IrSO functional job on ironic-images changes#620

Merged
metal3-io-bot merged 1 commit intometal3-io:mainfrom
dtantsur:irso-ci
Feb 10, 2025
Merged

🌱 Run the IrSO functional job on ironic-images changes#620
metal3-io-bot merged 1 commit intometal3-io:mainfrom
dtantsur:irso-ci

Conversation

@dtantsur
Copy link
Member

@dtantsur dtantsur commented Feb 5, 2025

Signed-off-by: Dmitry Tantsur dtantsur@protonmail.com

@metal3-io-bot metal3-io-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 5, 2025
@metal3-io-bot metal3-io-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 5, 2025
@dtantsur dtantsur force-pushed the irso-ci branch 3 times, most recently from ec28154 to ce0a242 Compare February 5, 2025 13:29
tuminoid
tuminoid reviewed Feb 5, 2025
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nitting.

When finished, most of the changes should be applied in workflow in IRSO as well as this is mostly a copy from there.

@dtantsur dtantsur force-pushed the irso-ci branch 3 times, most recently from e39a1f3 to b788e1f Compare February 5, 2025 16:46
@dtantsur dtantsur changed the title [WIP] 🌱 Run the IrSO functional job on ironic-images changes 🌱 Run the IrSO functional job on ironic-images changes Feb 5, 2025
@metal3-io-bot metal3-io-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 5, 2025
@dtantsur dtantsur requested a review from tuminoid February 5, 2025 17:18
@dtantsur
Copy link
Member Author

dtantsur commented Feb 5, 2025

/override metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main

(does not involve integration tests in any way)

@metal3-io-bot
Copy link
Contributor

metal3-io-bot commented Feb 5, 2025

@dtantsur: Overrode contexts on behalf of dtantsur: metal3-centos-e2e-integration-test-main, metal3-ubuntu-e2e-integration-test-main

Details

In response to this:

/override metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main

(does not involve integration tests in any way)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@elfosardo
Copy link
Member

elfosardo commented Feb 6, 2025

/approve

@metal3-io-bot
Copy link
Contributor

metal3-io-bot commented Feb 6, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elfosardo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 6, 2025
@dtantsur
Copy link
Member Author

dtantsur commented Feb 6, 2025

@tuminoid metal3-io/ironic-standalone-operator#123 is the follow-up

tuminoid
tuminoid reviewed Feb 10, 2025
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noting the trigger inconsistency which can be fixed in follow-up, if wanted. I'll add a hold, if you want to address it now, and if not, then just unhold.
/hold

Otherwise this is LGTM and is a good cross-check addition.
/lgtm

@metal3-io-bot metal3-io-bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. labels Feb 10, 2025
tuminoid
tuminoid reviewed Feb 10, 2025
View reviewed changes
This was referenced Feb 10, 2025
Merged
Merged
Merged
Merged
@metal3-io-bot metal3-io-bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 10, 2025
@dtantsur
Copy link
Member Author

dtantsur commented Feb 10, 2025

/override metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main

@metal3-io-bot
Copy link
Contributor

metal3-io-bot commented Feb 10, 2025

@dtantsur: Overrode contexts on behalf of dtantsur: metal3-centos-e2e-integration-test-main, metal3-ubuntu-e2e-integration-test-main

Details

In response to this:

/override metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dtantsur dtantsur requested a review from tuminoid February 10, 2025 12:56
@dtantsur
Copy link
Member Author

dtantsur commented Feb 10, 2025

/unhold

PTAL @tuminoid

@metal3-io-bot metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 10, 2025
tuminoid
tuminoid reviewed Feb 10, 2025
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was checking the action's logs, and found two nits about apt.

Workflow itself seems to work.

@dtantsur
Run the IrSO functional job on ironic-images changes
e0b6f0b 
Signed-off-by: Dmitry Tantsur <dtantsur@protonmail.com>
@dtantsur dtantsur requested a review from tuminoid February 10, 2025 13:29
@dtantsur
Copy link
Member Author

dtantsur commented Feb 10, 2025

/override metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main

@metal3-io-bot
Copy link
Contributor

metal3-io-bot commented Feb 10, 2025

@dtantsur: Overrode contexts on behalf of dtantsur: metal3-centos-e2e-integration-test-main, metal3-ubuntu-e2e-integration-test-main

Details

In response to this:

/override metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tuminoid
tuminoid reviewed Feb 10, 2025
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 10, 2025
@metal3-io-bot metal3-io-bot merged commit 2d743b0 into metal3-io:main Feb 10, 2025
7 checks passed
@metal3-io-bot metal3-io-bot added this to the ironic-image - v28.0 milestone Feb 10, 2025
@dtantsur dtantsur deleted the irso-ci branch February 10, 2025 15:02
iurygregory pushed a commit to iurygregory/ironic-image that referenced this pull request Oct 11, 2025
@openshift-merge-bot
Merge pull request metal3-io#620 from iurygregory/OCPBUGS-48150
6aca641 
[4.18] OCPBUGS-48150: Bump jinja2 to 3.1.5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tuminoid tuminoid tuminoid left review comments

@elfosardo elfosardo Awaiting requested review from elfosardo

@zaneb zaneb Awaiting requested review from zaneb

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

ironic-image - v28.0

Development

Successfully merging this pull request may close these issues.

4 participants

@dtantsur @metal3-io-bot @elfosardo @tuminoid