🌱 workflows: sync pull_request trigger types#885
🌱 workflows: sync pull_request trigger types#885metal3-io-bot merged 1 commit intometal3-io:mainfrom
Conversation
We have "edited" as leftover workaround from days before we had "PR auto-reapprover" workflow in some jobs. In some jobs it is specifically needed as those workflows check the PR metadata which is covered by the edited. Add "ready_for_review" for consistency as a trigger type as well. Similar PRs will be pushed across Metal3 repos to make things consistent after discussion in ironic-image PR. Signed-off-by: Tuomo Tanskanen <tuomo.tanskanen@est.tech>
metal3-io-bot
added
the
size/S
|
/hold Since the idea is to get these consistent, I'm holding until all of the PRs have flags. |
metal3-io-bot
added
the
do-not-merge/hold
|
/override metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main |
|
@tuminoid: Overrode contexts on behalf of tuminoid: metal3-centos-e2e-integration-test-main, metal3-ubuntu-e2e-integration-test-main DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cc @kashifest @lentzi90 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lentzi90 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
metal3-io-bot
added
the
approved
|
/unhold |
metal3-io-bot
removed
the
do-not-merge/hold
|
/cc @Rozzii |
|
/lgtm |
4 participants
We have "edited" as leftover workaround from days before we had "PR auto-reapprover" workflow in some jobs. In some jobs it is specifically needed as those workflows check the PR metadata which is covered by the edited. Add "ready_for_review" for consistency as a trigger type as well.
Similar PRs will be pushed across Metal3 repos to make things consistent after discussion in ironic-image PR.