Prevent first row from always being removed in submission tab data merge #1886
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eecavanna
reviewed
Dec 12, 2025
eecavanna
approved these changes
Dec 12, 2025
Collaborator
eecavanna
left a comment
eecavanna
left a comment
There was a problem hiding this comment.
LGTM! Thanks for taking care of this issue, which was a release-blocker.
Collaborator
|
I'll go ahead and merge this into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1885
In the Vue 3 upgrade an overly permissive truth-y check was added in order to satisfy stricter type-checking. In this code
environmentRowcan beundefinedor a number. The function should returntrueifenvironmentRowis zero. So the fix is to explicitly check forundefinedbefore doing the numeric check.Secondarily, I noticed in the screenshots in the linked issue that the badge showing the number of validation errors was being clipped by the tab container with Vuetify 3. I'm fixing that here by changing the badge to be
inlineso that it's not absolutely positioned and actually takes up computable space in the tab.