fix #https://github.com/microsoft/vscode-dev/issues/1366#291731
Merged
fix #https://github.com/microsoft/vscode-dev/issues/1366#291731
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts extension version filtering so platform-specific builds only replace universal/undefined builds when they share the same version number (preventing a lower platform-specific version from overriding a higher universal version), addressing microsoft/vscode-dev#1366.
Changes:
- Update
filterLatestExtensionVersionsForTargetPlatformto only prefer a target-platform-specific version over universal/undefined when the version strings match. - Add clarifying JSDoc explaining the filtering/replacement rules and input ordering assumptions.
- Update and expand unit tests to cover the corrected replacement behavior and a real-world mixed universal/platform-specific scenario.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/vs/platform/extensionManagement/common/extensionGalleryService.ts | Tightens replacement logic to require matching version numbers before preferring platform-specific builds; adds documentation for the behavior. |
| src/vs/platform/extensionManagement/test/common/extensionGalleryService.test.ts | Updates/extends tests to validate that higher universal versions are not replaced by lower platform-specific ones, and that same-version replacement still works. |
justschen
approved these changes
Jan 29, 2026
auto-merge was automatically disabled
January 29, 2026 21:12
Pull request was closed
This was referenced Jan 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix https://github.com/microsoft/vscode-dev/issues/1366