Skip to content

fix #https://github.com/microsoft/vscode-dev/issues/1366#291731

Merged
pwang347 merged 1 commit intomainfrom
sandy081/bad-armadillo
Jan 29, 2026
Merged

fix #https://github.com/microsoft/vscode-dev/issues/1366#291731
pwang347 merged 1 commit intomainfrom
sandy081/bad-armadillo

Conversation

@sandy081
Copy link
Member

@sandy081 sandy081 commented Jan 29, 2026

Copilot AI review requested due to automatic review settings January 29, 2026 20:40
@sandy081 sandy081 enabled auto-merge (squash) January 29, 2026 20:40
@sandy081 sandy081 self-assigned this Jan 29, 2026
@vs-code-engineering vs-code-engineering bot added this to the January 2026 milestone Jan 29, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adjusts extension version filtering so platform-specific builds only replace universal/undefined builds when they share the same version number (preventing a lower platform-specific version from overriding a higher universal version), addressing microsoft/vscode-dev#1366.

Changes:

  • Update filterLatestExtensionVersionsForTargetPlatform to only prefer a target-platform-specific version over universal/undefined when the version strings match.
  • Add clarifying JSDoc explaining the filtering/replacement rules and input ordering assumptions.
  • Update and expand unit tests to cover the corrected replacement behavior and a real-world mixed universal/platform-specific scenario.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/vs/platform/extensionManagement/common/extensionGalleryService.ts Tightens replacement logic to require matching version numbers before preferring platform-specific builds; adds documentation for the behavior.
src/vs/platform/extensionManagement/test/common/extensionGalleryService.test.ts Updates/extends tests to validate that higher universal versions are not replaced by lower platform-specific ones, and that same-version replacement still works.

@sandy081 sandy081 closed this Jan 29, 2026
auto-merge was automatically disabled January 29, 2026 21:12

Pull request was closed

@sandy081 sandy081 reopened this Jan 29, 2026
@rzhao271 rzhao271 closed this Jan 29, 2026
@rzhao271 rzhao271 reopened this Jan 29, 2026
@pwang347 pwang347 merged commit e83c168 into main Jan 29, 2026
66 of 80 checks passed
@pwang347 pwang347 deleted the sandy081/bad-armadillo branch January 29, 2026 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants