chore(proto): drop the orphaned ethermint feemarket protos and generated api code#316
Merged
Merged
Conversation
…ted api code The in-tree x/feemarket was replaced by cosmos/evm's (cosmos.evm.feemarket.v1 protos, shipped with the module); ethermint.feemarket.v1 has had zero importers since — no gogo types, no keeper, nothing outside api/. The protos only survived because make proto-gen kept regenerating dead pulsar code from the dead sources, and buf push was republishing them to moca's BSR. ethermint/types/v1/account.proto is deliberately untouched: EthAccount is the type URL of every persisted account. Signed-off-by: puneetmahajan <59960662+puneet2019@users.noreply.github.com>
puneet2019
force-pushed
the
chore/drop-orphaned-ethermint-feemarket-protos
branch
from
708852e to
22e8e23
Compare
phenix3443
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the shrink-to-upstream campaign (#309–#314).
Summary
ethermint.feemarket.v1is orphaned: the in-treex/feemarketwas replaced by cosmos/evm's (cosmos.evm.feemarket.v1, generated code shipped with the module), and since then these protos have zero importers — no gogo types, no keeper, nothing outsideapi/. They only survived becausemake proto-genkept regenerating dead pulsar code from the dead.protosources — andbuf pushwas republishing the dead protos to moca's BSR.Change (−7,099 / +1)
proto/ethermint/feemarket/v1/(5 protos) andapi/ethermint/feemarket/v1/(7 generated files).ethermint/types/v1/account.proto—EthAccountis the type URL of every persisted account (see the encoding audit); it must stay.Safety
x/feemarket; the pulsar registry decodes nothing that is stored.go build ./...green locally and on an amd64 box.Expected CI reds (both have the #310 merge precedent)
break-check— flags the 5 deleted protos as breaking. Intentional: the package is dead and its successor lives in cosmos/evm's namespace (cosmos.evm.feemarket.v1).lint(buf) — only runs because this PR touchesproto/; it then flags pre-existing enum-style debt in unrelatedproto/moca/*files (FeePreviewType,ResourceType,ACTION_*values — none touched here). Verified: zero findings in files this PR changes.🤖 Generated with Claude Code