Fix: detect multisig type from input cells in deploy #652
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eval-exec
force-pushed
the
exec/fix-deploy-multisig-config-should-deduce-multisig-version-based-on-input-cell
branch
from
5513ca0 to
3827f0c
Compare
Signed-off-by: Eval EXEC <[email protected]>
eval-exec
force-pushed
the
exec/fix-deploy-multisig-config-should-deduce-multisig-version-based-on-input-cell
branch
from
3827f0c to
23d8fcb
Compare
This was referenced Nov 26, 2025
eval-exec
requested review from
XuJiandong,
doitian,
driftluo,
quake and
zhangsoledad
XuJiandong
approved these changes
Nov 27, 2025
quake
approved these changes
Dec 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When upgrading deployed scripts,
build_tx()incorrectly used thedeployment.tomlconfig to determine which multisig type (Legacy/V2) to use for unlocking input cells. This caused failures when upgrading from Legacy to V2 multisig locks.ckb-cli should detect multisig type (Legacy/V2) from actual input cell locks instead of deployment config.
Request for review: @XuJiandong @sunchengzhu @quake @zhangsoledad @driftluo