Skip fastqc#1056
Closed
jorondo1 wants to merge 4 commits into
Closed
Conversation
Release 5.4.2
…logic in main.nf to conditionally run FASTQC_RAW and FASTQC_TRIMMED
Member
|
Warning Newer version of the nf-core template is available. Your pipeline is using an old version of the nf-core template: 3.5.2. For more documentation on how to update your pipeline, please see the nf-core documentation and Synchronisation documentation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
Please keep in mind this is my first ever "real" pull request, i-e in a collaborative setting. I'm hoping I did everything right!
Changes:
Added --skip_fastqc switch (default: false) that skips both FASTQC_RAW and FASTQC_TRIMMED steps in short-read preprocessing. Lot of it is redundant with fastp reports, which is sufficient for me. Parameter is declared in nextflow_schema.json and handled conditionally in subworkflows/local/shortread_preprocessing.nf
Code lint
This is new to me, I feel like the warnings and errors here do not concern what I’ve modified but I’m not sure if there’s something I should be doing about them?
╭─ [?] 1 Pipeline Test Ignored ────────────────────────────────────────────────────────────────────────────────╮
│ │
│ files_unchanged: File ignored due to lint config: .github/PULL_REQUEST_TEMPLATE.md │
│ │
╰──────────────────────────────────────────────────────────────────────────────────────────────────────────────╯
╭─ [!] 2 Pipeline Test Warnings ───────────────────────────────────────────────────────────────────────────────╮
│ │
│ nextflow_config: Config manifest.version should end in dev: 5.4.2 │
│ nfcore_yml: nf-core version in .nf-core.yml is not set to the latest version. Should be 3.4.1 but was 3.5.2 │
│ │
╰──────────────────────────────────────────────────────────────────────────────────────────────────────────────╯
╭─ [✗] 2 Pipeline Tests Failed ────────────────────────────────────────────────────────────────────────────────╮
│ │
│ files_unchanged: .github/workflows/linting.yml does not match the template │
│ files_unchanged: assets/nf-core-mag_logo_light.png does not match the template │
│ │
╰──────────────────────────────────────────────────────────────────────────────────────────────────────────────╯
– [x] Tests
with
`[de/1c4d8d] NFCORE_MAG:MAG:BINNING:MAXBIN2 (test_minigut_sample2) | 4 of 4, ignored: 1 ✔
– [x] Check for unexpected warnings in debug mode (
nextflow run . -profile debug,test,docker --outdir <OUTDIR>).not sure what to look for here, I do see
Usage Documentation in
docs/usage.mdis updated.N/A
Output Documentation in
docs/output.mdis updated.N/A
CHANGELOG.mdis updated.Wasn’t sure how to do this since it’s not a release, so I left a note. Again this is all pretty new to me!
README.mdis updated (including new tool citations and authors/contributors).N/A