Skip to content

Conversation

@jialinli98
Copy link
Contributor

@jialinli98 jialinli98 commented Jul 11, 2025

Description

Add benchmark support to bigcurve library using github-action-benchmark.
The setup follows the same approach as bignum library.

  • Benchmarks run automatically on PRs.

  • Results are published to the gh-pages branch under /dev/bench

  • Baseline comparisons are made against the main branch

Problem*

closes #86

Summary*

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@github-project-automation github-project-automation bot moved this to 👀 To Triage in Noir Libraries Jul 11, 2025
@jialinli98 jialinli98 changed the title add benchmark feat: add benchmark Jul 14, 2025
@jialinli98 jialinli98 force-pushed the jl/benchmark branch 3 times, most recently from 4bf83f8 to 079d96d Compare July 15, 2025 05:12
@jialinli98 jialinli98 changed the title feat: add benchmark feat: add benchmarks Jul 15, 2025
@jialinli98
Copy link
Contributor Author

jialinli98 commented Jul 15, 2025

I don't have permission to add https://noir-lang.github.io/noir_bigcurve/dev/bench/ page to Bigcurve library.

@jialinli98 jialinli98 requested a review from TomAFrench July 15, 2025 15:51
Copy link
Member

@TomAFrench TomAFrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@kashbrti kashbrti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good work. LGTM

@jialinli98 jialinli98 merged commit 54de613 into main Jul 16, 2025
9 checks passed
@github-project-automation github-project-automation bot moved this from 👀 To Triage to ✅ Done in Noir Libraries Jul 16, 2025
@github-actions github-actions bot mentioned this pull request Jul 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Archived in project

Development

Successfully merging this pull request may close these issues.

Add benchmark support

4 participants