-
Notifications
You must be signed in to change notification settings - Fork 4
feat: add benchmarks #87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4bf83f8 to
079d96d
Compare
Contributor
Author
|
I don't have permission to add https://noir-lang.github.io/noir_bigcurve/dev/bench/ page to Bigcurve library. |
TomAFrench
reviewed
Jul 15, 2025
TomAFrench
approved these changes
Jul 15, 2025
Member
TomAFrench
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
TomAFrench
reviewed
Jul 15, 2025
kashbrti
approved these changes
Jul 15, 2025
Contributor
kashbrti
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good work. LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add benchmark support to bigcurve library using github-action-benchmark.
The setup follows the same approach as bignum library.
Benchmarks run automatically on PRs.
Results are published to the gh-pages branch under /dev/bench
Baseline comparisons are made against the main branch
Problem*
closes #86
Summary*
Additional Context
PR Checklist*
cargo fmton default settings.