Fix reward function logic in direct locomotion environments #19
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reward computation in the direct locomotion environment had unnecessarily complex and error-prone logic that could lead to maintenance issues. This PR simplifies and clarifies the reward function implementation while maintaining identical numerical behavior.
Issues Fixed
1. Overcomplicated heading reward computation:
2. Confusing up reward computation:
Benefits
LocomotionEnvValidation
Mathematical validation confirms that the simplified implementation produces identical numerical results to the original code. The changes are purely a code quality improvement with no behavioral modifications.
Fixes #7.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.