-
Notifications
You must be signed in to change notification settings - Fork 1.9k
[chore][RFC] Semantic conventions migrations in the Collector #14273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #14273 +/- ##
==========================================
- Coverage 91.83% 91.82% -0.02%
==========================================
Files 677 677
Lines 42679 42679
==========================================
- Hits 39195 39190 -5
- Misses 2427 2430 +3
- Partials 1057 1059 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ChrsMark
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good, thank's for writing this!
I only have some concerns about specific details.
This comment was marked as outdated.
This comment was marked as outdated.
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Co-authored-by: Damien Mathieu <42@dmathieu.com>
|
Thanks for your comments @dmathieu @lmolkova @ChrsMark! I marked this as ready for review because it feels like there is some agreement on the overall shape, but there are still details to figure out. Trying to summarize the main points that we need to discuss:
Do you have a strong opiniong on either of these two? Are there any other big questions to resolve? From my side:
|
sounds great, I really like 'legacy' / 'v1', it works especially well with the collector since it's on v0 |
I like it too! Maybe instead of Maybe we can consider including in this RFC the decided names for components like That being said, I think this RFC LGTM and once we finalise the naming I'll approve. Thank's again for putting this together @mx-psi! |
|
I think we should have an explicit number of versions we keep the flag/duplicate conventions for. In otelhttp, we did the following:
I believe a couple versions is fine for unstable components. Maybe 4 for stable ones? |
|
@dmathieu Added some wording about the timeline, specifying 4 releases (8 weeks) for each. Does that seem reasonable? It's unclear to me what the equivalent should be in the Collector SIG to what the Go SIG does given the differences in release cadence. Also, I would rather not make a distinction between unstable and stable components for this if that's okay with you and just put the more strict requirement for both (but if you think that's too stringent let's discuss) |
Co-authored-by: Damien Mathieu <42@dmathieu.com>
|
cc @open-telemetry/collector-approvers We need at least two approvals for this since this is an RFC so I would like more feedback from approvers |
Co-authored-by: Jade Guiton <jade.guiton@datadoghq.com>
|
@open-telemetry/collector-approvers This is entering final comment period, I will merge this on Monday, January 26th 2026 or after if there are no objections before then. |
17646a7
Description
RFC about dealing with semantic conventions migrations.
This would be applicable to semantic conventions migrations related to RPC, system metrics, Kubernetes metrics and attributes...
RFC Checklist