-
Notifications
You must be signed in to change notification settings - Fork 35
Display only directly assigned roles in user modal #1251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display only directly assigned roles in user modal #1251
Conversation
Use Run test server using develop.opencast.org as backend:
Specify a different backend like stable.opencast.org:
It may take a few seconds for the interface to spin up. |
This pull request is deployed at test.admin-interface.opencast.org/1251/2025-05-16_06-42-38/ . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works, but I would like to see the filtering happen outside the SelectContainer component. Imo it is the task of the calling components to provide the correct data.
Did you test this with users with many roles (upwards of a thousand)? Is it performant?
adbe9a9
to
ef618cc
Compare
Not only assigned but also derived roles were display in the "Roles" tab of the user modal.
ef618cc
to
8c2c112
Compare
Thanks for the review @Arnei. I did address your suggestions and did move the filtering to the UserDetails component. Code is ready for an other review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I click on "Add user" and click on the "Roles" tab in the "Create new user" modal, the ui breaks (white screen).
As with the user details view, we also need to provide the assignedRoles attribute in the New User dialogue.
Since the new user dialog also uses the SelectContainer, I had to add the assignedRoles attribute to the NewUserWizard as well. Now, creating a new user and assigning roles simultaneously is working again. |
Everything else is looking fine now. |
Reduce the attributes of handleSubmit when updating or creating a user.
* upstream/r/17.x: (191 commits) Revert "Merge branch 'seperate-user-and-non-user-roles' of Arnei/opencast-admin-interface into main" Automatically update translation keys Uncheck 'Select all' header cell on page change (opencast#1196) Automatically update translation keys Changing themes of series fixed (opencast#1254) Display only directly assigned roles in user modal (opencast#1251) Reactivated location table sorting by udated date Implement broadcast synchronization for logout events and user authentication (opencast#1274) make cancel buttons work for users/groups/access (opencast#1277) Different text for bottom set of roles in ACL view make sure override is there where needed make override optional Modernize the `Dockerfile` deselect all items in the table before sorting Minor eslint fixes Fix checkbox name for contact me field in RegistrationModal fix overlapping notifications + add title in upload notification minor fixes Add override button functionality to access policy components for series, Add two tabs indentation ...
fix #1239
This fix ensures that only directly assigned roles are displayed in the roles tab of the user modal.