Skip to content

Conversation

@Nil20
Copy link
Contributor

@Nil20 Nil20 commented Dec 4, 2025

Farajaland PR: opencrvs/opencrvs-farajaland#1857
CC PR: opencrvs/opencrvs-countryconfig#1169

Description

Clearly describe what has been changed. Include relevant context or background.
Explain how the issue was fixed (if applicable) and the root cause.

Link this pull request to the GitHub issue (and optionally name the branch ocrvs-<issue #>)

Checklist

  • I have linked the correct Github issue under "Development"
  • I have tested the changes locally, and written appropriate tests
  • I have tested beyond the happy path (e.g. edge cases, failure paths)
  • I have updated the changelog with this change (if applicable)
  • I have updated the GitHub issue status accordingly

@github-actions
Copy link

github-actions bot commented Dec 4, 2025

Oops! Looks like you forgot to update the changelog. When updating CHANGELOG.md, please consider the following:

  • Changelog is read by country implementors who might not always be familiar with all technical details of OpenCRVS. Keep language high-level, user friendly and avoid technical references to internals.
  • Answer "What's new?", "Why was the change made?" and "Why should I care?" for each change.
  • If it's a breaking change, include a migration guide answering "What do I need to do to upgrade?".

@Nil20 Nil20 linked an issue Dec 4, 2025 that may be closed by this pull request
@Nil20 Nil20 added the Skip e2e Helps run lint/unit test only for faster feedback. Remove before merge. label Dec 4, 2025
Copy link
Contributor

@cibelius cibelius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of small comments. Could you also go through the workflow with Jon before merging, so we make sure its working as intended?

@Nil20 Nil20 requested a review from cibelius December 5, 2025 12:53
@Nil20 Nil20 removed the Skip e2e Helps run lint/unit test only for faster feedback. Remove before merge. label Dec 5, 2025
@Nil20 Nil20 added the 🔒 Keep e2e Don't delete E2E environment after testing label Dec 5, 2025
@ocrvs-bot
Copy link
Contributor

Your environment is deployed to https://ocrvs-11215.e2e-k8s.opencrvs.dev

@Nil20 Nil20 merged commit 5912104 into develop Dec 9, 2025
195 of 198 checks passed
@Nil20 Nil20 deleted the ocrvs-11215 branch December 9, 2025 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🔒 Keep e2e Don't delete E2E environment after testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Configure 'Approval of late registration' -workflow

4 participants