-
Notifications
You must be signed in to change notification settings - Fork 69
Configure ISSUE_CERTIFIED_COPY custom action #1180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Oops! Looks like you forgot to update the changelog. When updating CHANGELOG.md, please consider the following:
|
|
@jpye-finch has asked to keep the configurations as is for now, since there could be new configurations regarding this flow could be forthcoming (e.g. |
| { | ||
| label: { | ||
| defaultMessage: 'Mother', | ||
| id: 'form.field.label.app.whoContDet.mother', | ||
| description: 'Label for mother' | ||
| }, | ||
| value: 'MOTHER' | ||
| }, | ||
| { | ||
| label: { | ||
| defaultMessage: 'Father', | ||
| id: 'form.field.label.informantRelation.father', | ||
| description: 'Label for father' | ||
| }, | ||
| value: 'FATHER' | ||
| }, | ||
| { | ||
| label: { | ||
| defaultMessage: 'Someone else', | ||
| id: 'form.field.label.informantRelation.others', | ||
| description: 'Label for someone else' | ||
| }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
translations of these labels are already in client.csv
Note
Currently, we do not run e2e tests as a check on
opencrvs-countryconfig-repo PRs. Please ensure your PR doesn't break any e2e tests.One method for doing this is to open a PR with these changes to
opencrvs-farajalandas well, and see if the PR check passes there.Description
Clearly describe what has been changed. Include relevant context or background.
Explain how the issue was fixed (if applicable) and the root cause.
Link this pull request to the GitHub issue (and optionally name the branch
ocrvs-<issue #>)Checklist