Skip to content

Conversation

@Nil20
Copy link
Contributor

@Nil20 Nil20 commented Dec 9, 2025

Note

Currently, we do not run e2e tests as a check on opencrvs-countryconfig-repo PRs. Please ensure your PR doesn't break any e2e tests.

One method for doing this is to open a PR with these changes to opencrvs-farajaland as well, and see if the PR check passes there.

Description

Clearly describe what has been changed. Include relevant context or background.
Explain how the issue was fixed (if applicable) and the root cause.

Link this pull request to the GitHub issue (and optionally name the branch ocrvs-<issue #>)

Checklist

  • I have linked the correct Github issue under "Development"
  • I have tested the changes locally, and written appropriate tests
  • I have tested beyond the happy path (e.g. edge cases, failure paths)
  • I have updated the changelog with this change (if applicable)
  • I have updated the GitHub issue status accordingly

@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2025

Oops! Looks like you forgot to update the changelog. When updating CHANGELOG.md, please consider the following:

  • Changelog is read by country implementors who might not always be familiar with all technical details of OpenCRVS. Keep language high-level, user friendly and avoid technical references to internals.
  • Answer "What's new?", "Why was the change made?" and "Why should I care?" for each change.
  • If it's a breaking change, include a migration guide answering "What do I need to do to upgrade?".

@Nil20
Copy link
Contributor Author

Nil20 commented Dec 9, 2025

@jpye-finch has asked to keep the configurations as is for now, since there could be new configurations regarding this flow could be forthcoming (e.g. e-signet flow could affect the print/issue flow). So, e2e tests can be added later after confirmation.

Comment on lines +313 to +334
{
label: {
defaultMessage: 'Mother',
id: 'form.field.label.app.whoContDet.mother',
description: 'Label for mother'
},
value: 'MOTHER'
},
{
label: {
defaultMessage: 'Father',
id: 'form.field.label.informantRelation.father',
description: 'Label for father'
},
value: 'FATHER'
},
{
label: {
defaultMessage: 'Someone else',
id: 'form.field.label.informantRelation.others',
description: 'Label for someone else'
},
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

translations of these labels are already in client.csv

@Nil20 Nil20 merged commit 5949fcd into develop Dec 10, 2025
2 checks passed
@Nil20 Nil20 deleted the ocrvs-11263 branch December 10, 2025 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants