-
Notifications
You must be signed in to change notification settings - Fork 291
Fix: combine image and version field for initHelper of chart in opensearch-cluster (>=3.0.0) #1040
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: combine image and version field for initHelper of chart in opensearch-cluster (>=3.0.0) #1040
Conversation
Signed-off-by: Marcel Yeonghyeon Ko <[email protected]>
Signed-off-by: Marcel Yeonghyeon Ko <[email protected]>
{{- with .Values.cluster.initHelper }} | ||
initHelper: {{ . | toYaml | nindent 4 }} | ||
initHelper: | ||
{{- omit . "image" | toYaml | nindent 4 }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems enough to add image
field like spec.dashboards
for now, but it anyone has a better idea, feel free to share your suggestion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@YeonghyeonKO thanks for the PR!
I feel this should be sufficient.
Signed-off-by: yeonghyeonKo <[email protected]>
# initHelper configuration | ||
initHelper: | ||
# -- initHelper image | ||
image: docker.io/busybox |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: yeonghyeonKo <[email protected]>
Thanks for reviewing the PR, @rootxrishabh ! |
Description
image
field in the opensearch-cluster chart and deployed it. I would recommend this stopgap for the current release version.spec.dashboards
orspec.general
, I suggest to fix it by:Issues Resolved
Check List
make lint
)If CRDs are changed:
make manifests
) and also copied into the helm chartPlease refer to the PR guidelines before submitting this pull request.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.