Skip to content

Conversation

YeonghyeonKO
Copy link
Contributor

@YeonghyeonKO YeonghyeonKO commented Jun 27, 2025

Description

  • For a quick fix to this issue (without any change in templates), I used an image field in the opensearch-cluster chart and deployed it. I would recommend this stopgap for the current release version.
# initHelper configuration
initHelper:
  image: "harbor.abc.com/nexus/docker-mig/library/busybox:1.31.1"
  imagePullPolicy: IfNotPresent
  • However, if opensearch-k8s-operator follows the principle of specifying the version of image separately like spec.dashboards or spec.general, I suggest to fix it by:
  {{- with .Values.cluster.dashboards }}
  dashboards:
    {{- omit . "image" | toYaml | nindent 4 }}
    image: {{ .image }}:{{ .version }}
  {{- end }}
  {{- with .Values.cluster.general }}
  general:
    {{- omit . "image" "serviceName" | toYaml | nindent 4 }}
    image: {{ .image }}:{{ .version }}
    serviceName: {{ .serviceName | default $clusterName }}
  {{- end }}
  {{- with .Values.cluster.initHelper }}
    {{- omit . "image" | toYaml | nindent 4 }}
    image: {{ .image }}:{{ .version }}
  {{- end }}

Issues Resolved

Check List

  • Commits are signed per the DCO using --signoff
  • Unittest added for the new/changed functionality and all unit tests are successful
  • Customer-visible features documented
  • No linter warnings (make lint)

If CRDs are changed:

  • CRD YAMLs updated (make manifests) and also copied into the helm chart
  • Changes to CRDs documented

Please refer to the PR guidelines before submitting this pull request.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

{{- with .Values.cluster.initHelper }}
initHelper: {{ . | toYaml | nindent 4 }}
initHelper:
{{- omit . "image" | toYaml | nindent 4 }}
Copy link
Contributor Author

@YeonghyeonKO YeonghyeonKO Jun 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems enough to add image field like spec.dashboards for now, but it anyone has a better idea, feel free to share your suggestion.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@YeonghyeonKO thanks for the PR!
I feel this should be sufficient.

@YeonghyeonKO YeonghyeonKO changed the title Fix: combine image and version field for initHelper of chart in opensearch-cluster-3.1.0 Fix: combine image and version field for initHelper of chart in opensearch-cluster (>=3.0.0) Jun 27, 2025
# initHelper configuration
initHelper:
# -- initHelper image
image: docker.io/busybox
Copy link
Contributor Author

@YeonghyeonKO YeonghyeonKO Jul 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@YeonghyeonKO YeonghyeonKO requested a review from rootxrishabh July 6, 2025 09:54
@YeonghyeonKO
Copy link
Contributor Author

Thanks for reviewing the PR, @rootxrishabh !
If there's any remaining issues, feel free to ping me.
cc: @prudhvigodithi

@prudhvigodithi prudhvigodithi merged commit e5103bf into opensearch-project:main Jul 30, 2025
11 checks passed
@github-project-automation github-project-automation bot moved this from 👀 In Review to ✅ Done in Engineering Effectiveness Board Jul 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

3 participants