Skip to content

Fix: combine image and version field for initHelper of chart in opensearch-cluster (>=3.0.0) #1040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 30, 2025
Merged

Fix: combine image and version field for initHelper of chart in opensearch-cluster (>=3.0.0) #1040

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
de4f51c
fix: combine `image` and `version` field
YeonghyeonKO Jun 27, 2025
57b828a
add: `image` field for cluster.initHelper in values.yaml
YeonghyeonKO Jun 27, 2025
f4da237
fix: specify the correct initHelper image(docker.io/busybox)
YeonghyeonKO Jul 6, 2025
e8bbb68
add: include the missing field(cluster.initHelper.image)
YeonghyeonKO Jul 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions charts/opensearch-cluster/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,7 @@ A Helm chart for OpenSearch Cluster
| cluster.ingress.opensearch.enabled | bool | `false` | Enable ingress for Opensearch service |
| cluster.ingress.opensearch.hosts | list | `[]` | Opensearch Ingress hostnames |
| cluster.ingress.opensearch.tls | list | `[]` | Opensearch tls configuration |
| cluster.initHelper.image | string | `"docker.io/busybox"` | initHelper image |
| cluster.initHelper.imagePullPolicy | string | `"IfNotPresent"` | initHelper image pull policy |
| cluster.initHelper.imagePullSecrets | list | `[]` | initHelper image pull secret |
| cluster.initHelper.resources | object | `{}` | initHelper pod cpu and memory resources |
Expand Down
4 changes: 3 additions & 1 deletion charts/opensearch-cluster/templates/cluster.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,9 @@ spec:
serviceName: {{ .serviceName | default $clusterName }}
{{- end }}
{{- with .Values.cluster.initHelper }}
initHelper: {{ . | toYaml | nindent 4 }}
initHelper:
{{- omit . "image" | toYaml | nindent 4 }}
Copy link
Contributor Author

@YeonghyeonKO YeonghyeonKO Jun 27, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems enough to add image field like spec.dashboards for now, but it anyone has a better idea, feel free to share your suggestion.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@YeonghyeonKO thanks for the PR!
I feel this should be sufficient.

image: {{ .image }}:{{ .version }}
{{- end }}
{{- with .Values.cluster.nodePools }}
nodePools: {{ . | toYaml | nindent 4 }}
Expand Down
3 changes: 3 additions & 0 deletions charts/opensearch-cluster/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,6 +225,9 @@ cluster:

# initHelper configuration
initHelper:
# -- initHelper image
image: docker.io/busybox
Copy link
Contributor Author

@YeonghyeonKO YeonghyeonKO Jul 6, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in sync with the design of CRD version 2.8.0


# -- initHelper image pull policy
imagePullPolicy: "IfNotPresent"

Expand Down