Skip to content

CONSOLE-4439: Drop support of React Router 5 #14957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

vojtechszocs
Copy link
Contributor

Work in progress 🚧

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 10, 2025
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 10, 2025
@vojtechszocs vojtechszocs marked this pull request as draft April 10, 2025 16:01
@openshift-ci openshift-ci bot added component/core Related to console core functionality component/dashboard Related to dashboard approved Indicates a PR has been approved by an approver from all required OWNERS files. component/dev-console Related to dev-console component/gitops Related to gitops-plugin component/helm Related to helm-plugin component/knative Related to knative-plugin component/metal3 Related to metal3-plugin component/monitoring Related to monitoring component/olm Related to OLM component/pipelines Related to pipelines-plugin component/sdk Related to console-plugin-sdk component/shared Related to console-shared component/topology Related to topology plugin-api-changed Categorizes a PR as containing plugin API changes labels Apr 10, 2025
@logonoff
Copy link
Member

/label tide/merge-method-squash

@openshift-ci openshift-ci bot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Apr 11, 2025
@logonoff
Copy link
Member

/retest NO-JIRA: Drop support of React Router 5 (wip)
/retest

Copy link
Contributor

openshift-ci bot commented Apr 11, 2025

@logonoff: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

/test analyze
/test backend
/test e2e-gcp-console
/test frontend
/test images
/test okd-scos-images

The following commands are available to trigger optional jobs:

/test okd-scos-e2e-aws-ovn

Use /test all to run all jobs.

In response to this:

/retest NO-JIRA: Drop support of React Router 5 (wip)
/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@logonoff
Copy link
Member

/test all

@logonoff logonoff force-pushed the drop-react-router-v5 branch from 7827ca9 to b53853f Compare April 11, 2025 15:33
@vojtechszocs vojtechszocs changed the title WiP Drop support of React Router 5 Drop support of React Router 5 Apr 11, 2025
@vojtechszocs vojtechszocs marked this pull request as ready for review April 11, 2025 15:35
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 11, 2025
@openshift-ci openshift-ci bot requested a review from avivtur April 11, 2025 15:35
@logonoff
Copy link
Member

/retitle CONSOLE-4439; Drop support of React Router 5

@openshift-ci openshift-ci bot changed the title Drop support of React Router 5 CONSOLE-4439; Drop support of React Router 5 Apr 11, 2025
@logonoff
Copy link
Member

logonoff commented Apr 11, 2025

/retitle CONSOLE-4439: Drop support of React Router 5

@vojtechszocs vojtechszocs changed the title CONSOLE-4439; Drop support of React Router 5 CONSOLE-4439: Drop support of React Router 5 Apr 11, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 11, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 11, 2025

@vojtechszocs: This pull request references CONSOLE-4439 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Work in progress 🚧

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 14, 2025
@openshift-ci openshift-ci bot added the component/backend Related to backend label Apr 15, 2025
Copy link
Contributor

openshift-ci bot commented Apr 15, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vojtechszocs
Once this PR has been reviewed and has the lgtm label, please ask for approval from jhadvig. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 15, 2025
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 15, 2025
Copy link
Contributor

openshift-ci bot commented Apr 15, 2025

@vojtechszocs: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-console 5dccd49 link true /test e2e-gcp-console
ci/prow/frontend 5dccd49 link true /test frontend
ci/prow/okd-scos-e2e-aws-ovn 5dccd49 link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/backend Related to backend component/core Related to console core functionality component/dashboard Related to dashboard component/dev-console Related to dev-console component/gitops Related to gitops-plugin component/helm Related to helm-plugin component/knative Related to knative-plugin component/metal3 Related to metal3-plugin component/monitoring Related to monitoring component/olm Related to OLM component/pipelines Related to pipelines-plugin component/sdk Related to console-plugin-sdk component/shared Related to console-shared component/topology Related to topology jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. plugin-api-changed Categorizes a PR as containing plugin API changes tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants