Skip to content

Conversation

@t2gran
Copy link
Member

@t2gran t2gran commented Feb 10, 2025

Summary

This PR disable OptimizeTransfers for via search. The OptimizeTransfers does not work with via search as is. It is not implemented yet.

The plan is to support the via in TransferOptimization soon, but until then merging this PR into your code will make the via work.

Issue

There is no issue for this - this is a known limitation due to the fact that we have not implemented support for the feature.

Unit tests

🟥 Not relevant

Documentation

A comment is added to the code to explain why the TransferOptimization is temporarily turned off.

Changelog

🟥 Not relevant

Bumping the serialization version id

🟥 Not needed

@t2gran t2gran added the Entur Test This is currently being tested at Entur label Feb 10, 2025
@t2gran t2gran added this to the 2.7 (next release) milestone Feb 10, 2025
@t2gran t2gran requested a review from a team as a code owner February 10, 2025 18:52
@codecov
Copy link

codecov bot commented Feb 10, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 70.31%. Comparing base (62b4982) to head (5e3456a).
Report is 3 commits behind head on dev-2.x.

Files with missing lines Patch % Lines
.../algorithm/raptoradapter/router/TransitRouter.java 50.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             dev-2.x    #6449   +/-   ##
==========================================
  Coverage      70.31%   70.31%           
- Complexity     18158    18160    +2     
==========================================
  Files           2058     2058           
  Lines          76939    76942    +3     
  Branches        7771     7773    +2     
==========================================
+ Hits           54097    54102    +5     
+ Misses         20088    20086    -2     
  Partials        2754     2754           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@optionsome optionsome self-requested a review February 11, 2025 10:01
@t2gran t2gran merged commit 125f946 into opentripplanner:dev-2.x Feb 11, 2025
6 checks passed
@t2gran t2gran deleted the disable_via_optimized_transfers branch February 11, 2025 14:51
t2gran pushed a commit that referenced this pull request Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Entur Test This is currently being tested at Entur

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants