Skip to content

Conversation

@t2gran
Copy link
Member

@t2gran t2gran commented Dec 18, 2025

Summary

The existing code only remove real time trip updates with modified stop-patterns, not added trips(NeTEx ExtraJourney). If an ExtraJourney is canceled, the first update is not removed.

Issue

This is a follow up on #7052. We would like to do this in multiple PRs to minimize risk.

Unit tests

There is very few unit-tests testing the business rules in play here, none of the existing tests broke when this code was changed. I have not added new test - I want to replace this logic and in that case the test is not possible to reuse.

Documentation

🟥 No doc added.

Changelog

🟥 This is a follow up on #7052, it should be enough to mention the main issue/PR in the change log.

Bumping the serialization version id

🟥 Not needed-

This is needed to show extra journeys (added trips) on arrival/depature boards
The existing code only remove real time trip updates with modified stop-patterns, not added trips(NeTEx ExtraJourney). If an ExtraJourney is canceled, the first update is not removed.
@t2gran t2gran force-pushed the rm_old_realtime_updates_from_raptor_timetables branch from 8fd3d43 to 0ab03b8 Compare December 18, 2025 13:00
@codecov
Copy link

codecov bot commented Dec 18, 2025

Codecov Report

❌ Patch coverage is 88.46154% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.09%. Comparing base (67aa79d) to head (0ab03b8).
⚠️ Report is 9 commits behind head on dev-2.x.

Files with missing lines Patch % Lines
...tripplanner/transit/model/network/TripPattern.java 71.42% 1 Missing and 1 partial ⚠️
...nsit/mappers/RealTimeRaptorTransitDataUpdater.java 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             dev-2.x    #7146   +/-   ##
==========================================
  Coverage      72.09%   72.09%           
- Complexity     20695    20697    +2     
==========================================
  Files           2244     2244           
  Lines          83899    83911   +12     
  Branches        8347     8348    +1     
==========================================
+ Hits           60488    60497    +9     
- Misses         20482    20484    +2     
- Partials        2929     2930    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@t2gran t2gran added this to the 2.9 (next release) milestone Dec 18, 2025
@t2gran t2gran added !Bug Apply to issues describing a bug and PRs witch fixes it. +Skip Changelog This is not a relevant change for a product owner since last release. labels Dec 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

!Bug Apply to issues describing a bug and PRs witch fixes it. +Skip Changelog This is not a relevant change for a product owner since last release.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants