Remove old real time trip updates from Raptor timetables #7146
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The existing code only remove real time trip updates with modified stop-patterns, not added trips(NeTEx ExtraJourney). If an ExtraJourney is canceled, the first update is not removed.
Issue
This is a follow up on #7052. We would like to do this in multiple PRs to minimize risk.
Unit tests
There is very few unit-tests testing the business rules in play here, none of the existing tests broke when this code was changed. I have not added new test - I want to replace this logic and in that case the test is not possible to reuse.
Documentation
🟥 No doc added.
Changelog
🟥 This is a follow up on #7052, it should be enough to mention the main issue/PR in the change log.
Bumping the serialization version id
🟥 Not needed-