Pre Eigen 3.4 support and dropping the broken submodule ref#699
Draft
Pre Eigen 3.4 support and dropping the broken submodule ref#699
Conversation
akatumalla-ouster
approved these changes
Feb 27, 2026
| #include <Eigen/Core> | ||
|
|
||
| #if !EIGEN_VERSION_AT_LEAST(3,4,0) | ||
| namespace Eigen { |
Collaborator
There was a problem hiding this comment.
Suggested change
| namespace Eigen { | |
| namespace Eigen { | |
[nit] just for consistency with rest of the file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues & PRs
Summary of Changes
Validation
CI passes