Skip to content

Pre Eigen 3.4 support and dropping the broken submodule ref #699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Samahu wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Pre Eigen 3.4 support and dropping the broken submodule ref #699

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d4f53eb
Support for eigen pre-3.4
Samahu Feb 26, 2026
9b393e3
Remove the .gitmodules for ouster-sdk
Samahu Feb 26, 2026
fb1eee0
Add .gitmoduels back
Samahu Feb 26, 2026
0483198
Cleanup sdk-extenions again
Samahu Feb 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions .gitmodules
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +0,0 @@
[submodule "sdk-extensions"]
path = sdk-extensions
url = ../sdk-extensions.git
branch = master
17 changes: 17 additions & 0 deletions ouster_client/include/ouster/typedefs.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,23 @@
#pragma once
#include <Eigen/Core>

#if !EIGEN_VERSION_AT_LEAST(3,4,0)
namespace Eigen {
Copy link
Collaborator

@akatumalla-ouster akatumalla-ouster Feb 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
namespace Eigen {
namespace Eigen {

[nit] just for consistency with rest of the file.

template<typename Scalar, int Rows>
using Vector = Matrix<Scalar, Rows, 1>;

template<typename Scalar>
using Vector3 = Vector<Scalar, 3>;

template <typename Scalar>
using VectorX = Vector<Scalar, Eigen::Dynamic>;

template <typename Scalar>
using ArrayX = Array<Scalar, Eigen::Dynamic, 1>;

}
#endif

#include "ouster/visibility.h"

namespace ouster {
Expand Down
1 change: 0 additions & 1 deletion sdk-extensions
Open in desktop
Submodule sdk-extensions deleted from dcd66c