Skip to content

Allow PHPUnit 12 #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 13, 2025
Merged

Allow PHPUnit 12 #67

merged 2 commits into from
May 13, 2025

Conversation

Jean85
Copy link
Contributor

@Jean85 Jean85 commented Feb 7, 2025

This is a tentative PR to see if we can just widen the constraint or if we need more work.

@stof
Copy link
Member

stof commented Feb 7, 2025

the CI has not installed PHPUnit 12. Maybe there is another conflict somewhere

@alexander-schranz
Copy link

alexander-schranz commented Feb 7, 2025

Would think in prophecy sebastian package requirements: https://github.com/phpspec/prophecy/blob/a0165c648cab6a80311c74ffc708a07bb53ecc93/composer.json#L23-L25

@Jean85
Copy link
Contributor Author

Jean85 commented Feb 7, 2025

Would think in prophecy sebastian package requirements: https://github.com/phpspec/prophecy/blob/a0165c648cab6a80311c74ffc708a07bb53ecc93/composer.json#L23-L25

But that in turn has another conflict, which stops even PHPUnit 11 along the Prophecy chain: phpspec/phpspec#1483

If we can merget that, we can progress toward PHPUnit 12 too.

@alexander-schranz
Copy link

alexander-schranz commented May 12, 2025

looks like this can be updated as https://github.com/phpspec/phpspec/releases/tag/7.6.0 was released?

@Jean85
Copy link
Contributor Author

Jean85 commented May 12, 2025

Yes, also with phpspec/prophecy#643 I've tested that Prophecy runs smoothly with PHPUnit 11-12.

I'll try to rebase/force push to trigger another CI run.

@Jean85
Copy link
Contributor Author

Jean85 commented May 12, 2025

PHPUnit 12 successfully run under PHP 8.4 CI job: https://github.com/phpspec/prophecy-phpunit/actions/runs/14972640819/job/42056966767?pr=67#step:6:9
PHPUnit 11 successfully run under PHP 8.2 CI job: https://github.com/phpspec/prophecy-phpunit/actions/runs/14972640819/job/42056966733?pr=67#step:6:9

@stof can we merge & release here?

@stof stof merged commit d3c2804 into phpspec:master May 13, 2025
10 checks passed
@stof stof mentioned this pull request May 13, 2025
@Jean85 Jean85 deleted the phpunit-12-support branch May 13, 2025 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants