Merged
Conversation
Adds end-to-end hover tests covering classes, actors, traits, interfaces, primitives, aliases, type inference, receiver capabilities, complex types, generic types, and function signatures. Tests share a single LSP server instance that compiles the workspace once. Renames _hover_tests.pony to _hover_formatter_tests.pony to distinguish unit tests from integration tests.
Member
|
Im merged this. Some thoughts on improvements to consider:
|
This was referenced Apr 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
The
pony-lsptool provides LSP hover functionality but has no integration tests that exercise the full server lifecycle — only unit tests for the hover formatter exist.Changes
_hover_integration_tests.pony: end-to-end hover tests covering classes, actors, traits, interfaces, primitives, aliases, type inference, receiver capabilities, complex types (union/tuple), generic types, and function signaturestest/workspace/hover/used by the integration tests_hover_tests.pony→_hover_formatter_tests.pony(and_HoverTests→_HoverFormatterTests) to distinguish the formatter unit tests from the new integration testshover/formatter/*, integration tests usehover/integration/*Considerations
All integration tests share a single
_HoverWorkspaceServeractor that initializes and compiles the workspace once, then dispatches individual hover requests to each test'sTestHelper. This avoids repeated compilation overhead but means tests run sequentially through one server instance.