hw: Add Multicast capabilities #123
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove unwanted files and update .gitignore remove unwanted files Restore files and fix .gitignore gitignore Delete work_axi_mesh_xy directory Delete work directory a a add necessary file add git workflows del tcl.txt
fischeti
force-pushed
the
fischeti/new-mcast
branch
2 times, most recently
from
961ba7f to
a58146a
Compare
fischeti
force-pushed
the
fischeti/new-mcast
branch
from
a58146a to
a196bfb
Compare
Lore0599
reviewed
Apr 24, 2025
Lore0599
force-pushed
the
fischeti/new-mcast
branch
from
966e2c9 to
bbbdc57
Compare
Lore0599
reviewed
Apr 28, 2025
| @@ -29,6 +30,8 @@ module floo_nw_chimney #( | |||
| /// Every atomic transactions needs to have a unique ID | |||
| /// and one ID is reserved for non-atomic transactions | |||
| parameter int unsigned MaxAtomicTxns = 1, | |||
| // TODO(fischeti): Move to RouteCfg | |||
There was a problem hiding this comment.
What do you mean with the TODO comment? @fischeti
There was a problem hiding this comment.
I would put the EnMultiCast parameter into the RouteCfg structure that is passed
Lore0599
reviewed
Apr 28, 2025
Lore0599
reviewed
Apr 28, 2025
Lore0599
force-pushed
the
fischeti/new-mcast
branch
from
78942e9 to
9552ac5
Compare
Lore0599
force-pushed
the
fischeti/new-mcast
branch
from
9552ac5 to
457eb0b
Compare
Lore0599
reviewed
May 9, 2025
| // Solderpad Hardware License, Version 0.51, see LICENSE for details. | ||
| // SPDX-License-Identifier: SHL-0.51 | ||
| // | ||
| // Author: Tim Fischer <[email protected]> |
There was a problem hiding this comment.
@fischeti Do we really need this module? I think is not used anywhere, can I remove it?
There was a problem hiding this comment.
It was intended for the reduction in the router, but you can also remove it
Lore0599
reviewed
May 9, 2025
| // Solderpad Hardware License, Version 0.51, see LICENSE for details. | ||
| // SPDX-License-Identifier: SHL-0.51 | ||
| // | ||
| // Author: Chen Wu <[email protected]> |
There was a problem hiding this comment.
This module is not used anymore since the logic has now be merged in the floo_id_translation. Can I remove it?
Lore0599
reviewed
May 9, 2025
hw/floo_route_comp.sv
Outdated
There was a problem hiding this comment.
We are not using anymore the routre_comp module. This oculd be removed as well.
Lore0599
force-pushed
the
fischeti/new-mcast
branch
from
47ae340 to
8f8ef29
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Collective communication: Multicast
Adds multicast and basic reduction capabilities to FlooNoC. This PR supersedes #116
TODO:
axi,idma)ReduceMask