Conversation
hoyer-a
requested review from
a team,
SimonBuechner,
ahms5,
artur-pa,
f-brinkmann and
mberz
f-brinkmann
approved these changes
Jan 13, 2026
Member
f-brinkmann
left a comment
f-brinkmann
left a comment
There was a problem hiding this comment.
Looks fine as a bugfix before we tackle #116.
| is_energy=False, | ||
| time_shift=True, | ||
| channel_independent=False, | ||
| channel_independent=True, |
Member
There was a problem hiding this comment.
These were wrong before to counter the bug, right?
Member
Author
There was a problem hiding this comment.
Yes, it appears like the channel_independent=True and channel_independent=False behavior was swapped.
github-project-automation
bot
moved this from Backlog
to Reviewer Approved
in Weekly Planning
This was referenced Jan 16, 2026
SimonBuechner
approved these changes
Jan 20, 2026
github-project-automation
bot
moved this from Require review
to Reviewer Approved
in Weekly Planning
mberz
approved these changes
Jan 21, 2026
github-project-automation
bot
moved this from Reviewer Approved
to Done
in Weekly Planning
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
channel_independent=True/normalization=Truetakes the nanmax per channel and divides the edc by itchannel_independent=False/normalization=Truetakes the nanmax across all channels and divides the edc by itnp.nanmaxis usedNote
The case presented in the weekly works correctly now.