Skip to content

[torchx][ci] Pin pip-25.0.1 since pip-25.1 breaks editable installs of torchx[dev] #1059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 2, 2025

Conversation

kiukchung
Copy link
Contributor

Solves python unittests failing with:

ERROR: Exception:
Traceback (most recent call last):
  File "/opt/hostedtoolcache/Python/3.9.22/x64/lib/python3.9/site-packages/pip/_internal/cli/base_command.py", line 105, in _run_wrapper
    status = _inner_run()
  File "/opt/hostedtoolcache/Python/3.9.22/x64/lib/python3.9/site-packages/pip/_internal/cli/base_command.py", line 96, in _inner_run
    return self.run(options, args)
  File "/opt/hostedtoolcache/Python/3.9.22/x64/lib/python3.9/site-packages/pip/_internal/cli/req_command.py", line 68, in wrapper
    return func(self, options, args)
  File "/opt/hostedtoolcache/Python/3.9.22/x64/lib/python3.9/site-packages/pip/_internal/commands/install.py", line 421, in run
    reqs_to_build = [
  File "/opt/hostedtoolcache/Python/3.9.22/x64/lib/python3.9/site-packages/pip/_internal/commands/install.py", line 424, in <listcomp>
    if should_build_for_install_command(r)
  File "/opt/hostedtoolcache/Python/3.9.22/x64/lib/python3.9/site-packages/pip/_internal/wheel_builder.py", line 65, in should_build_for_install_command
    return _should_build(req)
  File "/opt/hostedtoolcache/Python/3.9.22/x64/lib/python3.9/site-packages/pip/_internal/wheel_builder.py", line 53, in _should_build
    assert req.source_dir
AssertionError

see: https://github.com/pytorch/torchx/actions/runs/14781211083/job/41500352685?pr=1057

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 1, 2025
@kiukchung kiukchung force-pushed the kiuk-dev branch 11 times, most recently from 3190b70 to 54704fc Compare May 1, 2025 23:20
@kiukchung kiukchung changed the title [torchx][CI] Upgrade pip prior to installing deps for python-unittests [torchx][ci] Pin pip-25.0.1 since pip-25.1 breaks editable installs of torchx[dev] May 2, 2025
@facebook-github-bot
Copy link
Contributor

@kiukchung has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@@ -7,7 +7,6 @@ kubernetes==25.3.0
flake8==3.9.0
fsspec==2024.3.1
s3fs==2024.3.1
google-api-core
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: removed because this is actually pinned to google-api-core==2.18.0 in L47 below and running pip install -r dev-requirements.txt fails if the same package is listed twice in this file.

@kiukchung kiukchung requested a review from d4l3k May 2, 2025 02:01
@facebook-github-bot facebook-github-bot merged commit b53d332 into main May 2, 2025
24 checks passed
@facebook-github-bot facebook-github-bot deleted the kiuk-dev branch May 2, 2025 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants