Skip to content

[torchx][ci] Pin pip-25.0.1 since pip-25.1 breaks editable installs of torchx[dev] #1059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 2, 2025
Merged

[torchx][ci] Pin pip-25.0.1 since pip-25.1 breaks editable installs of torchx[dev] #1059

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .github/workflows/python-unittests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,14 @@ jobs:
architecture: x64
- name: Checkout TorchX
uses: actions/checkout@v2
- name: Pin pip-25.0.1
run: |
set -eux
# required since pip-25.1 breaks a few old deps in dev-requirements.txt
# (upgrading those will take some time)
# see: https://pip.pypa.io/en/stable/news/#v25-1
python -m pip install pip==25.0.1
pip --version
- name: Install dependencies
run: |
set -eux
Expand Down
1 change: 0 additions & 1 deletion dev-requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ kubernetes==25.3.0
flake8==3.9.0
fsspec==2024.3.1
s3fs==2024.3.1
google-api-core
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: removed because this is actually pinned to google-api-core==2.18.0 in L47 below and running pip install -r dev-requirements.txt fails if the same package is listed twice in this file.

google-cloud-batch==0.17.14
google-cloud-logging==3.10.0
google-cloud-runtimeconfig==0.34.0
Expand Down
Loading