fix(quinn-udp): add Apple fast path API stubs for windows and fallback#2566
Closed
mxinden wants to merge 1 commit intoquinn-rs:mainfrom
Closed
fix(quinn-udp): add Apple fast path API stubs for windows and fallback#2566mxinden wants to merge 1 commit intoquinn-rs:mainfrom
mxinden wants to merge 1 commit intoquinn-rs:mainfrom
Conversation
Mirror the Apple fast datapath APIs to windows.rs and fallback.rs. See discussion in quinn-rs#2463 (comment).
Contributor
thomaseizinger
left a comment
There was a problem hiding this comment.
LGTM
Given that they are "experimental" as you said, maybe they should be gated on the feature being enabled?
Collaborator
Author
|
Turns out, this is a bit more complex than I thought: In Lines 345 to 364 in c67e9d8
Line 30 in c67e9d8 Thus e.g. on Linux, the APIs are currently not available. @thomaseizinger how should we proceed?
|
Contributor
I guess this is the better option then! |
Collaborator
Author
|
👍 will keep as is then, i.e. closing here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirror the Apple fast datapath APIs to windows.rs and fallback.rs.
See discussion in #2463 (comment).