Skip to content

fix(quinn-udp): add Apple fast path API stubs for windows and fallback #2566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mxinden wants to merge 1 commit into from
Closed

fix(quinn-udp): add Apple fast path API stubs for windows and fallback #2566

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions quinn-udp/src/fallback.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,20 @@ impl UdpSocketState {
pub fn may_fragment(&self) -> bool {
true
}

/// Stub: Apple's fast UDP datapath is not available on this platform.
///
/// # Safety
///
/// No-op on this platform. Present for API compatibility with the Unix implementation.
pub unsafe fn set_apple_fast_path(&self) {}

/// Returns whether Apple's fast UDP datapath is enabled for this socket.
///
/// Always returns `false` on this platform.
pub fn is_apple_fast_path_enabled(&self) -> bool {
false
}
}

fn send(socket: UdpSockRef<'_>, transmit: &Transmit<'_>) -> io::Result<()> {
Expand Down
14 changes: 14 additions & 0 deletions quinn-udp/src/windows.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -373,6 +373,20 @@ impl UdpSocketState {
pub fn may_fragment(&self) -> bool {
false
}

/// Stub: Apple's fast UDP datapath is not available on Windows.
///
/// # Safety
///
/// No-op on Windows. Present for API compatibility with the Unix implementation.
pub unsafe fn set_apple_fast_path(&self) {}

/// Returns whether Apple's fast UDP datapath is enabled for this socket.
///
/// Always returns `false` on Windows.
pub fn is_apple_fast_path_enabled(&self) -> bool {
false
}
}

fn send(
Expand Down