-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(global-header): added config for default header components #2263
feat(global-header): added config for default header components #2263
Conversation
The image is available at: |
/test e2e-tests |
3c47b55
to
bd34619
Compare
The image is available at: |
f54e4ea
to
b6c9481
Compare
The image is available at: |
174e308
to
9439980
Compare
The image is available at: |
The image is available at: |
df4e737
to
d7becf7
Compare
The image is available at: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small change request
1e35b77
to
0bc2227
Compare
The image is available at: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The plugin doesn't define this components yet, so this code couldn't be found.
As discussed in Slack. You must update the plugin to the latest release as well.
I share this here so that others see that this PR is on hold until the plugin is updated. :)
0bc2227
to
0c5aa5f
Compare
/retest |
The image is available at: |
/retest |
The image is available at: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
verified this on a cluster
/lgtm
Looks good. Verified on a cluster /lgtm |
The image is available at: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: christoph-jerolimov, debsmita1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The image is available at: |
Signed-off-by: Yi Cai <[email protected]>
New changes are detected. LGTM label has been removed. |
The image is available at: |
/cherry-pick release-1.5 |
@christoph-jerolimov: once the present PR merges, I will cherry-pick it on top of In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
12bb302
into
redhat-developer:main
@christoph-jerolimov: #2263 failed to apply on top of branch "release-1.5":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
…at-developer#2263) * feat(global-header): added config for default header components Signed-off-by: Yi Cai <[email protected]> * prettier fix Signed-off-by: Yi Cai <[email protected]> * hide header items in sidebar Signed-off-by: Yi Cai <[email protected]> * resolve failed ci checks Signed-off-by: Yi Cai <[email protected]> * resolve failed ci checks Signed-off-by: Yi Cai <[email protected]> * updated header component mp name Signed-off-by: Yi Cai <[email protected]> * added icons and updated global header config Signed-off-by: Yi Cai <[email protected]> * addressed review comments Signed-off-by: Yi Cai <[email protected]> * updated global header wrapper to take the latest release Signed-off-by: Yi Cai <[email protected]> * removed default support button url Signed-off-by: Yi Cai <[email protected]> * resolved merging conflicts Signed-off-by: Yi Cai <[email protected]> * addressed review comments Signed-off-by: Yi Cai <[email protected]> * updated theme package to pick up changes for global header Signed-off-by: Yi Cai <[email protected]> * fix: align application header mountpoint with other mount points Signed-off-by: Christoph Jerolimov <[email protected]> * fixed double scrollbar issue Signed-off-by: Yi Cai <[email protected]> * small pickup Signed-off-by: Yi Cai <[email protected]> * prettier fix Signed-off-by: Yi Cai <[email protected]> * updated default global header config Signed-off-by: Yi Cai <[email protected]> * fixed global header version Signed-off-by: Yi Cai <[email protected]> * fixed default global header config Signed-off-by: Yi Cai <[email protected]> * updated header package.json dependency Signed-off-by: Yi Cai <[email protected]> * ignore the problematic link Signed-off-by: Yi Cai <[email protected]> * updated yarn.lock Signed-off-by: Yi Cai <[email protected]> * code clean Signed-off-by: Yi Cai <[email protected]> * code clean Signed-off-by: Yi Cai <[email protected]> * added config to hide search and settings when header is enabled Signed-off-by: Yi Cai <[email protected]> * feat(global-header): use global-header 1.0.0 * feat(global-header): add optional layout config option for the header itself * docs(global-header): small fix * feat(global-header): enable new global-header plugin by default * fix(global-header): fix duplicate scrollbar issues (incl. RHIDP-4637) * chore(global-header): disable header in e2e tests for now * fix(global-header): fix duplicate scrollbar issues (incl. RHIDP-4637) * fix(global-header): fix duplicate scrollbar issues (incl. RHIDP-4637) * fix(global-header): fix duplicate scrollbar issues (incl. RHIDP-4637) * hide notifications from sidebar by default Signed-off-by: Yi Cai <[email protected]> --------- Signed-off-by: Yi Cai <[email protected]> Signed-off-by: Christoph Jerolimov <[email protected]> Co-authored-by: Christoph Jerolimov <[email protected]>
Description
Updated support to "tech-preview"Which issue(s) does this PR fix
PR acceptance criteria
Please make sure that the following steps are complete:
How to test changes / Special notes to the reviewer
workspaces/global-header/plugins/global-header/
directory runnpx --yes @janus-idp/cli package export-dynamic-plugin --dynamic-plugins-root <path-to-your-rhdh>/dynamic-plugins-root --dev
packages/app/package.json
, replace"@redhat-developer/red-hat-developer-hub-theme": "0.4.0",
with"@redhat-developer/red-hat-developer-hub-theme": "file:path/to/your/red-hat-developer-hub-theme",
app-config.local
file:Config
``` dynamicPlugins: rootDirectory: dynamic-plugins-root frontend: default.main-menu-items: menuItems: default.create: title: '' red-hat-developer-hub.backstage-plugin-global-header: mountPoints: - mountPoint: application/header importName: GlobalHeader config: position: above-main-content # above-main-content | below-main-content - mountPoint: global.header/component importName: SearchComponent config: priority: 100 - mountPoint: global.header/component importName: Spacer config: priority: 99 props: growFactor: 0 - mountPoint: global.header/component importName: HeaderIconButton config: priority: 90 props: title: Create... icon: add to: create - mountPoint: global.header/component importName: SupportButton config: priority: 80 - mountPoint: global.header/component importName: NotificationButton config: priority: 70 - mountPoint: global.header/component importName: Divider config: priority: 50 - mountPoint: global.header/component importName: ProfileDropdown config: priority: 10 - mountPoint: global.header/profile importName: MenuItemLink config: priority: 100 props: title: Settings link: /settings icon: manageAccounts - mountPoint: global.header/profile importName: LogoutButton config: priority: 10 ```app-config.yaml
helm chart with notifications plugin enabled
To test out the Notifications icon button, follow the below steps:
To set up notifications frontend, you can add to app-config.yaml:
To send notifications, you can setup external service https://backstage.io/docs/auth/service-to-service-auth/#static-keys-for-plugin-to-plugin-auth like this:
(Make sure this is auth under backend and not the top level auth key)
Then you can use this to send notifications:
Screen recording(uploaded Feb 7):
rhidp_5252_final.mp4