Skip to content

Add configuration option for reserved behavior xenvcfg.CBIE = 0b10 #1447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
challenger1024 wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add configuration option for reserved behavior xenvcfg.CBIE = 0b10 #1447

challenger1024 wants to merge 3 commits into from
+28 −3

Conversation

@challenger1024
Copy link
Contributor

@challenger1024 challenger1024 commented Dec 21, 2025 •
edited by Timmmm
Loading

The configuration option determines how to handle the reserved behavior xenvcfg.CBIE = 0b10.

  • "Xenvcfg_Fatal" – raise a Sail exception, stopping execution.
  • "Xenvcfg_ClearPermissions" – convert CBIE with 0b10 to 0b00.

@Timmmm Timmmm mentioned this pull request Dec 28, 2025
Open
16 tasks
Timmmm
Timmmm reviewed Dec 28, 2025
View reviewed changes
pmundkur
pmundkur reviewed Dec 29, 2025
View reviewed changes
@jordancarlin jordancarlin added the configuration Additional configuration settings needed for the model label Jan 6, 2026
@challenger1024 challenger1024 force-pushed the xenvcfg branch 4 times, most recently from 73c93e0 to ece3812 Compare January 12, 2026 06:41
@challenger1024
Copy link
Contributor Author

challenger1024 commented Jan 12, 2026

last push:

  • rebase;
  • change function name xenvcfg_helper to legalize_xenvcfg_cbie;
  • remove string type parameter in ligalize_xenvcfg_cbie;
  • add Xenvcfg_ prefix for enum type of XenvcfgCbieReservedBehavior.
    @Timmmm

@github-actions
Copy link

github-actions bot commented Jan 12, 2026 •
edited
Loading

Test Results

2 115 tests  ±0   2 115 ✅ ±0   23m 17s ⏱️ -3s
    1 suites ±0       0 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit 50a4a72. ± Comparison against base commit 397a7e8.

♻️ This comment has been updated with latest results.

Timmmm
Timmmm approved these changes Jan 12, 2026
View reviewed changes
Copy link
Collaborator

@Timmmm Timmmm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

jordancarlin
jordancarlin reviewed Jan 12, 2026
View reviewed changes
pmundkur
pmundkur requested changes Jan 12, 2026
View reviewed changes
Copy link
Collaborator

@pmundkur pmundkur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good; minor syntax issue and keeping the internal error as @jordancarlin requested.

@Timmmm Timmmm changed the title add configuration option for reserved behavior xenvcfg.CBIE = 0b10 Add configuration option for reserved behavior xenvcfg.CBIE = 0b10 Jan 13, 2026
@Timmmm Timmmm requested a review from pmundkur January 13, 2026 16:47
@pmundkur pmundkur added the will be merged Scheduled to be merged soon if nobody objects label Jan 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pmundkur pmundkur pmundkur approved these changes

@Timmmm Timmmm Timmmm approved these changes

@jordancarlin jordancarlin jordancarlin approved these changes

Assignees

No one assigned

Labels

configuration Additional configuration settings needed for the model will be merged Scheduled to be merged soon if nobody objects

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@challenger1024 @pmundkur @Timmmm @jordancarlin