Use bits(1) and 0b0/0b1 consistently in place of bit and bitone/bitzero
#1483
+234
−243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arichardson
reviewed
Jan 14, 2026
arichardson
reviewed
Jan 14, 2026
arichardson
approved these changes
Jan 14, 2026
Collaborator
arichardson
left a comment
arichardson
left a comment
There was a problem hiding this comment.
LGTM. No opinion on bit vs bits(1), both of those seem fine to me. If it was really common, I'd vote for bit but since there only seem to be about 20 uses, might as well use bits(1) for consistency.
pmundkur
approved these changes
Jan 14, 2026
Collaborator
pmundkur
left a comment
pmundkur
left a comment
There was a problem hiding this comment.
bits(1) seems fine to me. We should edit the PR message before merging.
jordancarlin
changed the title
bitzero and bitone with 0b0 and 0b1bits(1) and 0b0/0b1 consistently in place of bit and bitone/bitzero
jordancarlin
added
the
will be merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest version of Sail made
bitandbits(1)equivalent. Replace all instances ofbitzeroandbitonewith0b0and0b1for consistency.I haven't decided whether we should standardize on
bitorbits(1)for single-bit types. Anyone have an opinion? For now, I've gone withbits(1)just because it is more consistent with the other bitvectors.