Skip to content

Add support for Zcmt extension #757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

nadime15
Copy link
Contributor

@nadime15 nadime15 commented Feb 26, 2025

Hi everyone,

This pull request adds support for the Zcmt extension.

I’ve also included some simple tests, which can be found here.

  • Reading from the jump table vector requires Execute permission and supports both little and big endian formats. The current RISC-V Sail model only allows little-endian access, but I will add big-endian support after Big endianness Support added #751 is merged.
  • Check if Smstateen is implemented, requires state enable bit 2 in the appropriate stateen0 CSR. Will be added after Add Smstateen/Ssstateen extension regs #694 is merged.

One observation: at some point, it might make sense to introduce a more general interface for load and store. Since the Zcmp (#730) extension also requires these operations, a shared implementation could help reduce code duplication.

@nadime15
Copy link
Contributor Author

Hi @Timmmm, thanks for the suggestions! I've incorporated them and left some comments about a few small issues I ran into.

Copy link

github-actions bot commented Mar 17, 2025

Test Results

400 tests  ±0   400 ✅ ±0   1m 47s ⏱️ -2s
  1 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 15b5029. ± Comparison against base commit 97b7ed5.

♻️ This comment has been updated with latest results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
extension Adds support for a RISC-V extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants