-
Notifications
You must be signed in to change notification settings - Fork 204
Add support for Zcmt extension #757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
nadime15
wants to merge
1
commit into
riscv:master
Choose a base branch
from
nadime15:ext_zcmt
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Timmmm
requested changes
Feb 26, 2025
Hi @Timmmm, thanks for the suggestions! I've incorporated them and left some comments about a few small issues I ran into. |
Timmmm
reviewed
Mar 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi everyone,
This pull request adds support for the Zcmt extension.
I’ve also included some simple tests, which can be found here.
Smstateen
is implemented, requires state enable bit 2 in the appropriatestateen0
CSR. Will be added after Add Smstateen/Ssstateen extension regs #694 is merged.One observation: at some point, it might make sense to introduce a more general interface for
load
andstore
. Since the Zcmp (#730) extension also requires these operations, a shared implementation could help reduce code duplication.