Use C header generated by Sail #844
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This switches from manually copy & pasting model declarations to using Sail to generate the header.
|
I was looking at this while working on #494. This would be a great change. Once we get a number of bug fixes in, we might need a Sail 0.19.1 release for things like this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This switches from manually copy & pasting model declarations to using Sail to generate the header.
Draft because it doesn't quite work yet due to rems-project/sail#1215
It will also generate warnings until the next Sail release due to rems-project/sail#1205
The horrible
RISCV_MODEL_HEADERwill hopefully go away when we have runtime-configurable xlen and flen (I'm working on this).Also I think we may end up not using this if we do the C++
struct Model { #include "model.c" };trick, but I figured we may as well use it in the mean time.