CI macOS #867
Open
CI macOS #867
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordancarlin
requested changes
Apr 17, 2025
arichardson
reviewed
Apr 17, 2025
CMakeLists.txt
Outdated
| @@ -97,7 +97,7 @@ if (DOWNLOAD_GMP) | |||
| INTERFACE_INCLUDE_DIRECTORIES "${INSTALL_DIR}/include") | |||
| add_dependencies(GMP::GMP gmp) | |||
| else() | |||
| find_package(GMP) | |||
| find_package(GMP REQUIRED) | |||
There was a problem hiding this comment.
Required is missing here on purpose to provide a nicer error message, please drop this change.
|
Thanks for the comments, I will fix this later today. |
urbanij
force-pushed
the
furbani/ci-macos
branch
from
9d9486f to
3af3798
Compare
urbanij
force-pushed
the
furbani/ci-macos
branch
from
3af3798 to
5785365
Compare
Timmmm
requested changes
Apr 22, 2025
| @@ -18,6 +18,7 @@ target_include_directories(sail_runtime | |||
| PUBLIC "${sail_dir}/lib" | |||
| ) | |||
| target_compile_options(sail_runtime PRIVATE -Wno-extra -Wno-unused) | |||
| target_link_libraries(sail_runtime PUBLIC GMP::GMP) | |||
There was a problem hiding this comment.
I think with this here you can remove GMP::GMP from here:
target_link_libraries(riscv_sim_${arch}
PRIVATE softfloat sail_runtime default_config GMP::GMP
)
.github/workflows/compile.yml
Outdated
| if: startsWith(matrix.os, 'macos-') && steps.opam-cache.outputs.cache-hit != 'true' | ||
| run: | | ||
| opam init --auto-setup --bare | ||
| opam switch create default 4.14.1 |
There was a problem hiding this comment.
Probably could use OCaml 5 here?
.github/workflows/compile.yml
Outdated
| opam switch create default 4.14.1 | ||
| eval $(opam env) | ||
| opam update | ||
| opam install -y sail |
There was a problem hiding this comment.
I think we should lock the version (don't ask me how!).
There was a problem hiding this comment.
opam install -y sail.0.19 should work.
urbanij
force-pushed
the
furbani/ci-macos
branch
3 times, most recently
from
20cb907 to
f435677
Compare
urbanij
force-pushed
the
furbani/ci-macos
branch
from
f435677 to
bbbf159
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed macOS compilation issue and added to CI